- Nov 13, 2017
-
-
Arseny Kapoulkine authored
In compact mode, we currently can not support zero-allocation moves since some pointer assignments required during the move need to allocate hash table slots. This is mostly applicable to xml_document_struct::first_child, since the pointer to this element is used as a hash table key, but there are some contrived cases where parents of root's children need a hash slot and didn't have it before. These cases can be fixed by changing the compact encoding to be a bit more move friendly, but for now it's easier to handle the error and throw/return during move. When this happens, the source document doesn't change.
-
Arseny Kapoulkine authored
This allows us to do a single reserve for a known amount of assignments that is larger than the default minimum per reserve (16).
-
- Oct 30, 2017
-
-
Arseny Kapoulkine authored
These days OSX clang supports UB sanitizer so we can just use the same settings for all systems.
-
- Oct 26, 2017
-
-
Arseny Kapoulkine authored
These tests currently fail for compact mode because of ->reserve() failing.
-
- Oct 21, 2017
-
-
Arseny Kapoulkine authored
After move some nodes in the hash table can have keys that point to other; this makes the table somewhat larger but this does not impact correctness. The reason is that for us to access a key in the hash table, there should be a compact_pointer/string object with the state indicating that it is stored in a hash table, and with the address matching the key. For this to happen, we had to have put this object into this state which would mean that we'd overwrite the hash entry with the new, correct value. When nodes/pages are being removed, we do not clean up keys from the hash table - it's safe for the same reason, and thus move doesn't introduce additional contracts here.
-
Arseny Kapoulkine authored
We now check that appending a child to a moved document performs no allocations - this is already the case, but if we neglected to copy the allocator state this test would fail.
-
- Sep 26, 2017
-
-
Arseny Kapoulkine authored
Large test wasn't testing shared parent condition properly - add one more level of hierarchy so that it works as expected.
-
Arseny Kapoulkine authored
Add a test that checks that static buffer pointer was moved correctly by checking if offset_debug still works.
-
Arseny Kapoulkine authored
Make sure we have coverage for empty documents and for large documents that trigger compact_shared_parent != root for some pages.
-
Arseny Kapoulkine authored
Verify that move doesn't allocate and that it preserves structures required for tree memory management and append_buffer in tact.
-
Arseny Kapoulkine authored
-
Arseny Kapoulkine authored
These just verify that move ctor/assignment operator work as expected in simple cases - there are a number of ways in which the internal structure can be incorrect...
-
Arseny Kapoulkine authored
This change implements the initial version of move construction and assignment support for documents. When moving a document to another document, we always make sure move target is in "clean" state (empty document), and proceed by relocating all structures in the most efficient way possible. Complications arise from the fact that the root (document) node is embedded into xml_document object, so all pointers to it have to change; this includes parent pointers of all first-level children as well as allocator pointers in all memory pages and previous pointer in the first on-heap memory page. Additionally, compact mode makes everything even more complicated because some of the pointers we need to update are stored in the hash table (in fact, document first_child pointer is very likely to be there; some parent pointers in first-level children will be using compact_shared_parent but some won't be) which requires allocating a new hash table which can fail. Some details of this process are not fully fleshed out, especially for compact mode; and this definitely requires many tests.
-
- Sep 25, 2017
-
-
Arseny Kapoulkine authored
-
- Aug 30, 2017
-
-
Arseny Kapoulkine authored
It has always been the case that pugixml does not perform Unicode validation or name/tag Unicode character class validation, but it wasn't very obvious from documentation. Fixes #162
-
- Aug 22, 2017
-
-
Arseny Kapoulkine authored
We support Latin-1 and automatically detect it by parsing the encoding from document declaration; both of these were omitted from the description of the automatic detection. Additionally, the description has been rewritten to be more concise and a bit more abstract - there's no need to specify the algorithm precisely here. Fixes #158.
-
- Aug 20, 2017
-
-
Arseny Kapoulkine authored
Due to a typo in build script v141 binaries were built using VS2015 instead of VS2017. Fixes #157.
-
- Aug 18, 2017
-
-
Arseny Kapoulkine authored
Using LTCG restricts the resulting .lib files to a specific compiler version, causing version conflicts when the compiler gets updated without changing the toolset version. VS2017 now has two incompatible compilers, 15.0 and 15.3, both of which use toolset v141...
-
- Jul 18, 2017
-
-
Arseny Kapoulkine authored
Clang/C2 does not implement __builtin_expect; additionally we need to work around deprecation warnings for fopen by disabling them.
-
- Jun 29, 2017
-
-
Arseny Kapoulkine authored
Switch codecov.io URLs to https
-
Arseny Kapoulkine authored
-
- Jun 23, 2017
-
-
Arseny Kapoulkine authored
These new tests test that tellg() can fail when being called the second time, which leads to seekable implementation failing.
-
Arseny Kapoulkine authored
These tests simulate various error conditions when reading data from streams - seeks failing in seekable streams, underflow throwing an exception causing read to set badbit, etc. This change also adjusts memory thresholds to cause a reliable out of memory during construction of a final buffer for non-seekable streams.
-
Arseny Kapoulkine authored
-
Arseny Kapoulkine authored
This fixes missing coverage in translate_table_generate and xpath_node_set_raw::append.
-
Arseny Kapoulkine authored
Hiding using namespace in common.hpp is somewhat surprising so remove common.hpp and move using namespace into all .cpp files that need it.
-
Arseny Kapoulkine authored
Most tests have `using namespace pugi` which makes explicit qualifications unnecessary.
-
Arseny Kapoulkine authored
It's not clear whether we still need PUGI__MSVC_CRT_VERSION, but it's more consistent for now to use it for _snprintf_s since this is relying on a CRT extension, not on a compiler feature.
-
- Jun 22, 2017
-
-
Arseny Kapoulkine authored
These functions were deprecated via comments in 1.5 but never got the deprecated attribute; now is the time! Using deprecated functions produces a warning; to silence it, this change moves the relevant tests to a separate translation unit that has deprecation disabled.
-
- Jun 21, 2017
-
-
Arseny Kapoulkine authored
Rework NuGet package building
-
Arseny Kapoulkine authored
Unify build paths in all MSBuild VS projects and extract common build logic into functions. Note that this change changes both VS2010 and VS2013 projects to have more predictable output paths and fixed output file name (pugixml).
-
Arseny Kapoulkine authored
Also improve linkage description
-
Arseny Kapoulkine authored
We build NuGet package manually now so we don't need CoApp.
-
Arseny Kapoulkine authored
-
Arseny Kapoulkine authored
We'd like to build pugixml with both static & dynamic CRT and put it all in one NuGet package. CoApp sort of allows us to do this via dynamic/static pivots, but it does not let us customize the names of the pivots and additionally has some bugs with the project setup. Their project modifications are also much more complicated - really, at this point we should do this ourselves. Create a simple native NuGet package with Linkage setting that picks the right library, and package all libraries appropriately. Note that we use the unified path syntax to make it simple to just get the right .lib file from the toolset/platform/configuration/linkage combo.
-
- Jun 19, 2017
-
-
Arseny Kapoulkine authored
The macro only works correctly when the input argument is an array with a statically known size - pointers or arrays decayed to pointers won't work silently. While this is unlikely to surface issues that aren't caught in tests/code review, use _countof for MSVC to prevent such code from compiling.
-
Arseny Kapoulkine authored
Add VS2017 to AppVeyor test run
-
Arseny Kapoulkine authored
This requires moving the list of VS versions out of autotest-appveyor.ps1 and into appveyor.yml.
-
Arseny Kapoulkine authored
Correctly check for error codes and don't run .bat file since it doesn't work anyway (the variables it sets aren't accessible in PowerShell, and the path to the script doesn't seem to be the same in VS2017).
-
Arseny Kapoulkine authored
VS2017 project + NuGet support
-