Skip to content
Snippets Groups Projects
  1. Nov 12, 2018
  2. Oct 24, 2018
    • Arseny Kapoulkine's avatar
      XPath: Workaround Coverity false positive · d9fadc74
      Arseny Kapoulkine authored
      Coverity hits a similar false positive to what clang static analyzer hit
      - it assumes that since optimize() checks _right for being nullptr,
      optimize_self() might hit _right=nullptr in the ast_op_equal case which
      is impossible.
      
      Contributes to #236.
      d9fadc74
  3. Oct 16, 2018
    • Lipsa, Dan's avatar
      Remove warning in Visual Studio (#235) · 273fa0ab
      Lipsa, Dan authored
      The following warning is removed:
      Visual Studio 14.0
      1. warning C4275: non dll-interface class 'std::exception' used as
         base for dll-interface class 'vtkpugixml::xpath_exception'
      273fa0ab
  4. Sep 25, 2018
    • Arseny Kapoulkine's avatar
      Work around clang --analyze warnings · 81c82588
      Arseny Kapoulkine authored
      clang doesn't understand the invariants guaranteed for specific AST node
      types and, when seeing null pointer checks in optimize(), assumes any
      pointers in the node might be null. Work around this by adding explicit
      - redundant - null pointer checks.
      81c82588
    • Arseny Kapoulkine's avatar
      XPath: Refactor xpath_node_set short buffer optimization · e3b5e9ce
      Arseny Kapoulkine authored
      This change replaces xpath_node_set single element storage with a
      single-element array in hopes that this would silence Coverity false
      positive about getting a singleton pointer.
      
      Additionally, it refactors _assign member to unify small and large
      buffer codepaths since they are basically identical.
      
      Fixes #233 (hopefully)
      e3b5e9ce
  5. Aug 14, 2018
  6. Aug 08, 2018
  7. Jul 30, 2018
  8. Jul 28, 2018
  9. Jul 24, 2018
    • Arseny Kapoulkine's avatar
      Add .gitattributes file · f3139f4c
      Arseny Kapoulkine authored
      This makes sure the contents of tests/data/ folder does not go through
      newline conversion, which breaks tests that rely on some files having LF
      and some files having CR+LF.
      
      Fixes #222.
      f3139f4c
  10. Jul 23, 2018
  11. Jun 26, 2018
  12. Jun 20, 2018
  13. May 17, 2018
  14. Apr 27, 2018
    • Arseny Kapoulkine's avatar
      Move CMake build postfix setup behind an off-by-default USE_POSTFIX · 51322cff
      Arseny Kapoulkine authored
      This setup can interfere with existing workflows in two ways:
      
      - If the target application used CMake and configured custom postfixes,
      this change would override them
      
      - If the target application did *not* use CMake, it'd have to abide by
      these conventions even if the target configuration used is unexpected -
      for example, the default "preferred" configuration is frequently
      RelWithDebugInfo, not Release, which now has a postfix.
      
      Fixes #198.
      51322cff
  15. Apr 15, 2018
  16. Apr 12, 2018
  17. Apr 11, 2018
  18. Apr 09, 2018
    • Eli Schwartz's avatar
      cmake: always install the pkg-config file (#193) · daeb8013
      Eli Schwartz authored
      There's really never a reason to *not* want this installed. If an option
      is needed to specify installing in a versioned subdirectory, this option
      should be explicitly described rather than hidden in something else.
      
      As an added bonus, this makes the CMake install code slightly *less*
      complicated.
      daeb8013
  19. Apr 04, 2018
  20. Apr 03, 2018
  21. Mar 29, 2018
  22. Mar 17, 2018
    • Arseny Kapoulkine's avatar
      docs: Update changelog · cec32da2
      Arseny Kapoulkine authored
      Mention ubsan fixes; these fixes probably fix compact mode on some
      64-bit architecture where unaligned pointer reads aren't valid as well
      but it's probably not very relevant...
      cec32da2
    • Arseny Kapoulkine's avatar
      tests: Fix PUGIXML_COMPACT+PUGIXML_WCHAR_MODE tests · fe7b8378
      Arseny Kapoulkine authored
      Several tests got the buffer size wrong when sizeof(char_t)>1, and one
      test didn't meet the carefully tuned allocation criteria under compact
      mode due to the hash table usage and had to be changed a bit.
      fe7b8378
    • Arseny Kapoulkine's avatar
      ubsan: Fix undefined behavior for signed left shift in compact mode · e50672cf
      Arseny Kapoulkine authored
      We were using << compact_alignment_log2 instead of * compact_alignment
      for symmetry with the encoding where >> is crucial to keep code fast and
      round to negative infinity.
      
      For decoding, the results are the same and any reasonable compiler
      should convert *4 into <<2 so just use a multiplication - that doesn't
      trigger UB on negative numbers.
      e50672cf
  23. Mar 16, 2018
Loading