Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/mantidproject/mantid.git. Pull mirroring updated .
  1. Mar 31, 2020
  2. Mar 30, 2020
  3. Mar 26, 2020
  4. Mar 25, 2020
  5. Mar 23, 2020
    • Danny Hindson's avatar
    • Danny Hindson's avatar
      Update docs and add attenuation profile file to 2 algorithms · 2cfe853c
      Danny Hindson authored
      While the primary use of the new attenuation profile file feature is expected
      to be via the sample environment xml file, it also makes sense to add it into
      any algorithms where the material properties can be specified. So I've added a
      new attenuation profile parameter to the SetSampleMaterial and LoadSampleEnvironment
      algorithms. The validations on these algorithms means they can't be called using
      postional arguments so have inserted the new parameter in the logical place next
      to the absorption cross section
      
      Have updated the docs to explain how the attenuation profile file is used
      2cfe853c
  6. Mar 22, 2020
  7. Mar 20, 2020
    • Danny Hindson's avatar
      Add ability to load measured attenuation profile for material · 74316a4b
      Danny Hindson authored
      Add feature where an externally generated attenuation profile can be loaded into
      the material definition from a .DAT text file. This will override the normal
      exp(-alpha*thickness) calculation of the attenuation. The new feature was requested
      as part of the absorption calculation for the Pearl instrument where some parts
      of the environment are crystalline
      
      Found the lookup\interpolation on the loaded profile was slowing down the absorption
      Monte Carlo calculation.
      So improved performance of Kernel::Interpolation. Changed it to use vector of pairs
      instead of two separate vectors to reduce amount of navigation around vectors
      
      Considered adding feature into AttenuationProfile where I add any interpolated points
      into the override attenuation profile to prevent interpolation next iteration of
      Monte Carlo simulation. However wasn't convinced this was going to be thread-safe
      during the parallel part of the absorption calculation - may revisit this. While doing
      this investigation I fixed the following issues with the function Interpolation::AddPoint:
      
      a) it doesn't add the same point twice
      b) it reuses the lower_bound function rather than stepping through the vector sequentially
      
      I removed the exception from findIndexOfNextLargerValue because the end()
      iterator is a valid result if the x value supplied equals the last x value
      already in the vector. Could have left check in for begin() but didn't seem
      much point
      
      Finally - the interpolation outside the range is not v good. The data at the extremes
      is noisy so we end up extrapolating based on random gradient in extreme 2 points. Need
      to either fit or use more points to determine gradient
      74316a4b
    • Nick Draper's avatar
      Updated mantid copyright statement to add CSNS · 98cdc389
      Nick Draper authored
      Also updated class_maker.py
      98cdc389
  8. Mar 06, 2020
  9. Mar 02, 2020
  10. Feb 03, 2020
    • Danny Hindson's avatar
      Only use NumberOfWavelengthPoints if resimulating tracks · d48169a8
      Danny Hindson authored
      A new boolean parameter SimulateTracksForEachWavelength has been added to
      the MonteCarloAbsorption algorithm. This exposes a switch on the MCAbsorptionStrategy
      that was present before this change but was hardcoded to False.
      
      The parameter NumberOfWavelengthPoints is only required if SimulateTracksForEachWavelength
      is set to True. This change means that an attenuation factor is calculated for all wavelength
      bins if SimulateTracksForEachWavelength=false. To facilitate this a performance enhancement
      has been made to the Material class to calculate the total scatter cross section and the
      absorption cross section once when the Material rather than every time these cross sections
      are retrieved by the MonteCarloAbsorption calculation.
      
      This change required some unit and system tests to be updated eg ILLDirectGeometryReductionTest
      has been changed to remove the NumberOfWavelengthPoints parameter and the reference file to be
      updated. To make this test more robust I have increased the number of scenarios used in the MC
      simulation from 5000 to 20000
      d48169a8
  11. Jan 28, 2020
  12. Jan 22, 2020
  13. Jan 09, 2020
  14. Dec 20, 2019
    • Peterson, Peter's avatar
      Write out the units of simple values · c749ee7f
      Peterson, Peter authored
      Refs #27638
      c749ee7f
    • Gemma Guest's avatar
      Refactor the inner loop in splitByTimeVector · 23ef7e0d
      Gemma Guest authored
      The inner loop had a section to check the next value in the loop, which
      did the same as the next iteration of the main loop would do anyway.
      This commit consolidates it to just proceed to the next iteration in the
      loop.
      
      Also, the outer loop was originally split into two separate loops due to
      needing to continue if the inner loop ran out of values first. This
      commit also refactors the inner loop such that the outer loop can be
      performed in a single loop.
      23ef7e0d
  15. Dec 11, 2019
    • David Fairbrother's avatar
      Re #27022 Update inst when default facility is changed · 06f644b1
      David Fairbrother authored
      Updates the associated instrument to one from the facility when a
      facility is changed. This could fix numerous spurrious failures where
      unit tests will assume that a change in facility -> a change to an
      instrument from said facility
      06f644b1
    • David Fairbrother's avatar
      Refactor TSP Split By Vector · 4884c907
      David Fairbrother authored
      TimeSeriesProperty::SplitByTimeVector has a potential bug were
      exploring, however it is currently very difficult to understand. This
      commit refactors the method to make it readable
      4884c907
  16. Dec 06, 2019
  17. Dec 04, 2019
  18. Nov 25, 2019
  19. Nov 20, 2019
  20. Nov 08, 2019
  21. Nov 07, 2019
  22. Nov 06, 2019
Loading