as there is some strange interplay between datasearch.directories and defaultsave

Miscellaneous code review comments to add comments, remove redundant brackets
Also added comment to the sample environment concept page to explain where
Mantid will search for the attenuation profile file

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Runs clang-tidy pass by ref across the codebase to fix-up various
warnings we are seeing in cppcheck

Hand-fixes some cppcheck warnings, this was work prior to fixing the
cppcheck target.

While the primary use of the new attenuation profile file feature is expected
to be via the sample environment xml file, it also makes sense to add it into
any algorithms where the material properties can be specified. So I've added a
new attenuation profile parameter to the SetSampleMaterial and LoadSampleEnvironment
algorithms. The validations on these algorithms means they can't be called using
postional arguments so have inserted the new parameter in the logical place next
to the absorption cross section

Have updated the docs to explain how the attenuation profile file is used

Change absolute to absorption in comment against cross section types
Clarify formula in Materials concept page

Add feature where an externally generated attenuation profile can be loaded into
the material definition from a .DAT text file. This will override the normal
exp(-alpha*thickness) calculation of the attenuation. The new feature was requested
as part of the absorption calculation for the Pearl instrument where some parts
of the environment are crystalline

Found the lookup\interpolation on the loaded profile was slowing down the absorption
Monte Carlo calculation.
So improved performance of Kernel::Interpolation. Changed it to use vector of pairs
instead of two separate vectors to reduce amount of navigation around vectors

Considered adding feature into AttenuationProfile where I add any interpolated points
into the override attenuation profile to prevent interpolation next iteration of
Monte Carlo simulation. However wasn't convinced this was going to be thread-safe
during the parallel part of the absorption calculation - may revisit this. While doing
this investigation I fixed the following issues with the function Interpolation::AddPoint:

a) it doesn't add the same point twice
b) it reuses the lower_bound function rather than stepping through the vector sequentially

I removed the exception from findIndexOfNextLargerValue because the end()
iterator is a valid result if the x value supplied equals the last x value
already in the vector. Could have left check in for begin() but didn't seem
much point

Finally - the interpolation outside the range is not v good. The data at the extremes
is noisy so we end up extrapolating based on random gradient in extreme 2 points. Need
to either fit or use more points to determine gradient

Also updated class_maker.py

This commit removes the final header guard that had
been missed by the auto replacer.

re: #28200

This commit replaces all header guards in Kernel with #pragma once

Bumps span to the latest version and move the clone to configure time
rather than build time

Bumps the version of GTest to 1.10.0, removes the previous patching
steps, which are no longer needed. Removes the extra handling which is
provided in upstreams CMake, such as managing include directories

Git only converts CRLF to LF and not CR so to produce
the same SHA as git we must do the same.

A new boolean parameter SimulateTracksForEachWavelength has been added to
the MonteCarloAbsorption algorithm. This exposes a switch on the MCAbsorptionStrategy
that was present before this change but was hardcoded to False.

The parameter NumberOfWavelengthPoints is only required if SimulateTracksForEachWavelength
is set to True. This change means that an attenuation factor is calculated for all wavelength
bins if SimulateTracksForEachWavelength=false. To facilitate this a performance enhancement
has been made to the Material class to calculate the total scatter cross section and the
absorption cross section once when the Material rather than every time these cross sections
are retrieved by the MonteCarloAbsorption calculation.

This change required some unit and system tests to be updated eg ILLDirectGeometryReductionTest
has been changed to remove the NumberOfWavelengthPoints parameter and the reference file to be
updated. To make this test more robust I have increased the number of scenarios used in the MC
simulation from 5000 to 20000

Co-Authored-By: Conor Finn <47181718+ConorMFinn@users.noreply.github.com>

This commit adds tests to unit and PDFFourierTransform todo with the new atomic distance unit.

re: #27769

This commit adds atomic distance measured in units of angstroms to the unit factory

re: #27769

Newer boost bind seems to be causing
compiler warnings on Windows. It's no
longer required now bind is in the STL.
Refs #16578

Refs #16578

Add const

Co-Authored-By: Dan Nixon <dan@dan-nixon.com>

Add const

Co-Authored-By: Dan Nixon <dan@dan-nixon.com>

Refs #16578

Refs #27638

The inner loop had a section to check the next value in the loop, which
did the same as the next iteration of the main loop would do anyway.
This commit consolidates it to just proceed to the next iteration in the
loop.

Also, the outer loop was originally split into two separate loops due to
needing to continue if the inner loop ran out of values first. This
commit also refactors the inner loop such that the outer loop can be
performed in a single loop.

Windows devices have been running into issues in places where calling
the functions created to fix an issue on Unix machines in parallel
regions was causing error messages to  appear.

This is due to changes in implementation of omp_set_num_threads between
OpenMP v2 and v2.5+. As MSVC uses the older version of OpenMP I have
added a check that does not bother with the changes from the previous
fix if compiled with MSVC, as the original issue only appeared on non
MSVC compiled versions anyway.

Updates the associated instrument to one from the facility when a
facility is changed. This could fix numerous spurrious failures where
unit tests will assume that a change in facility -> a change to an
instrument from said facility