The fitpropertybrowser was segfaulting when creating the editors within the init.
This is because the maps containing the property managers and factories are not cleared in the browser destructor as the properties can still be used elsewhere. In testing however these are not cleared and result in pointers to the managers and factories remaining even though the manager has been deleted.
This commit removes the relevant editors from these maps when the destructor is called.

Add check to handle delete observer

Remove Bash 4.2 feature breaking Mac OSX

Removes a check that uses the -v flag, this was introduced in BASH 4.2,
so apparently breaks certain Mac builders

Fix cpp check 1.90 warnings

Change output ws names in Polaris.create_total_scattering_pdf

Emit Kafka exception msg when err callback used

Add quotes to Span patching step, in case there are spaces

Update sanitizers to use compiler instrumentation

Without this check every plot was being dedrawn every time a workspace was deleted from the ADS leading to slowdowns.

This function returns a bool which was previously being used to indicate two separate things. The return values could mean:
  * False: Either the workspace does not exist on the axis or it does but the axis is not empty after its' removal.
  * True: Workspace exists and was removed and axis is now empty

This made the value not very useful for determining whether a call to remove_workspace_artists had removed anything. A grep of the code base returned that this return value was not currently being used anywhere except in MantidAxes.cpp where it was assumed to indicate whether anything had been removed. As you can easily check whether an axis is empty by other means I have changed the return value so that it indicates whether the call resulted in any change to the plot which is harder to divine by other means and brings this function in line with replace_workspace_artist.

This commit removes a print statement initial added for debugging that was missed on cleaning up before pushing.

Determine the total number of detectors used in the spectrum info

Runs clang-tidy pass by ref across the codebase to fix-up various
warnings we are seeing in cppcheck

Hand-fixes some cppcheck warnings, this was work prior to fixing the
cppcheck target.

Updates the cppcheck target to run like a typical compilation. This
means CMake will fix-up the headers required on the fly. This reduces
the time compared to adding all headers, and improves the accuracy
significantly.

Adds clangd to the gitignore, this is generated by using the language
server on a source dir in VS code

Fixes sanitizers not switching off if USE_SANITIZER was set to off.
Additionally gets rid of a space between LSAN_OPTIONS and the actual
options, which was causing the suppressions file to be ignored.

Previously Kafka dropped the exception and just incremented using the
same callback our wait. This will now print the exception message
associated, so we can distinguish between a successful and failed
callback in unit test logs.

I could have made it so that the exception is thrown in the main thread
by taking a s_ptr. However it quickly becomes unweildly for a simple
probe, and we only gain the stack trace - which was already lost when
extractData re throws the exception.

Move FileDescriptor and NexusDescriptor includes to derived classes

Avoid extra multiply in Plus and Minus

Added Mantid::NeXus::NexusHDF5Descriptor class caching metadata

Populates Metadata entries in constructor
Internal reference accessible in public function
Added unit test
Address CI issue with POSIX strdup function

Improve Outputs When Focusing in Eng Diff 2 GUI

Change Algorithm State tracking

This commit adds release notes detailing the change of output names from Polaris.create_total_scattering_pdf

re: #28414

This commit adds lines in generate_ts_pdf to change the names of the workspaces produced as a result from the function.

re: #28414

Co-Authored-By: StephenSmith25 <56431339+StephenSmith25@users.noreply.github.com>

Adds quotes to the patching step for span in case there are spaces in
the path causing it to fail

Signed-off-by: Steven Hahn <hahnse@ornl.gov>