Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/mantidproject/mantid.git. Pull mirroring updated .
  1. Mar 27, 2020
    • Gemma Guest's avatar
      Fix a bug where restoring defaults affects all batches · 3c888dd8
      Gemma Guest authored
      Clicking restore-defaults on an Experiment or Instrument tab in a batch should only affect that tab and batch. This commit fixes a bug where a notification was sent to all batches, and every Experiment and Instrument tab was being reset. The fix is to separate updating the instrument (which is required to ensure we have up-to-date settings loaded from the instrument) from the subsequent notification which updates all batches. Instead, the particular Experiment/Instrument tab where the request was made restores its own defaults itself.
      
      Re #28429
      3c888dd8
  2. Mar 26, 2020
  3. Mar 20, 2020
  4. Mar 10, 2020
  5. Dec 16, 2019
    • Gemma Guest's avatar
      Add interface and mocks for encoder/decoder · ce15ec1e
      Gemma Guest authored
      These are now injected into the main window presenter's constructor so
      that they can be tested.
      
      Re #27242
      ce15ec1e
    • Gemma Guest's avatar
      Move Qt types out of presenter · 2daefbfe
      Gemma Guest authored
      - Move the QFileDialog implementation into the view so that the
      presenter does not need to know about it. Call the dialog functions via
      the IMessageHandler interface.
      - Move the save/load JSON functions into the view. Call them via a new
      IFileHandler interface. Note that not all Qt types are removed from the
      view's interface yet so a TODO has been added.
      
      Re #27242
      2daefbfe
  6. Nov 08, 2019
    • Gemma Guest's avatar
      Set the correct facility for the reflectometry GUI · 0a0b9c13
      Gemma Guest authored
      The reflectometry GUI sets the default instrument in the config service
      when it starts up to one of the ISIS reflectometers. This commit adds a
      check that the facility is ISIS and if not it sets the facility to ISIS.
      This avoids confusion where you essentially have invalid config. It also
      avoids confusion where e.g. loading runs from the default archive might
      not work because the archive may be a different facility.
      
      I have also added code to save the new config settings to file. Again
      this is to avoid confusion between what users see in mantid and what is
      in the saved settings. It is particularly confusing otherwise because
      Workbench will write settings to file when it closes but MantidPlot will not.
      
      Re #27241
      0a0b9c13
  7. Sep 19, 2019
  8. Sep 16, 2019
  9. Aug 14, 2019
  10. Aug 13, 2019
  11. Aug 12, 2019
  12. Aug 07, 2019
  13. Aug 01, 2019
  14. Jul 31, 2019
  15. Jun 28, 2019
  16. Jun 27, 2019
    • Gemma Guest's avatar
      Fix a crash when the help button is clicked · b3ddeda8
      Gemma Guest authored
      - This was to do with the way the presenter is created as an optional. It doesn't need to be an optional here - a unique pointer is better and makes ownership clearer.
      - This commit also includes some tidying of the MainWindowSubscriber which was being used incorrectly.
      - It also includes replacing some calls to m_presenter with calls to m_notifyee. They are the same object but we should use m_notifyee to be more in keeping with MVP. There is one remaining use of m_presenter in closeEvent but it is beyond the scope of this PR to fix that.
      
      Re #23027
      b3ddeda8
  17. Jun 21, 2019
  18. Jan 02, 2019
Loading