Fix a bug where restoring defaults affects all batches
Clicking restore-defaults on an Experiment or Instrument tab in a batch should only affect that tab and batch. This commit fixes a bug where a notification was sent to all batches, and every Experiment and Instrument tab was being reset. The fix is to separate updating the instrument (which is required to ensure we have up-to-date settings loaded from the instrument) from the subsequent notification which updates all batches. Instead, the particular Experiment/Instrument tab where the request was made restores its own defaults itself. Re #28429
Showing
- docs/source/release/v5.1.0/reflectometry.rst 4 additions, 1 deletiondocs/source/release/v5.1.0/reflectometry.rst
- qt/scientific_interfaces/ISISReflectometry/GUI/Experiment/ExperimentPresenter.cpp 1 addition, 1 deletion.../ISISReflectometry/GUI/Experiment/ExperimentPresenter.cpp
- qt/scientific_interfaces/ISISReflectometry/GUI/Instrument/InstrumentPresenter.cpp 1 addition, 1 deletion.../ISISReflectometry/GUI/Instrument/InstrumentPresenter.cpp
- qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/MainWindowPresenter.cpp 19 additions, 11 deletions.../ISISReflectometry/GUI/MainWindow/MainWindowPresenter.cpp
- qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/MainWindowPresenter.h 2 additions, 1 deletion...es/ISISReflectometry/GUI/MainWindow/MainWindowPresenter.h
- qt/scientific_interfaces/test/ISISReflectometry/MainWindow/MainWindowPresenterTest.h 15 additions, 3 deletions...st/ISISReflectometry/MainWindow/MainWindowPresenterTest.h
Loading
Please register or sign in to comment