Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/mantidproject/mantid.git. Pull mirroring updated .
  1. Mar 27, 2020
    • Gemma Guest's avatar
      Fix a bug where restoring defaults affects all batches · 3c888dd8
      Gemma Guest authored
      Clicking restore-defaults on an Experiment or Instrument tab in a batch should only affect that tab and batch. This commit fixes a bug where a notification was sent to all batches, and every Experiment and Instrument tab was being reset. The fix is to separate updating the instrument (which is required to ensure we have up-to-date settings loaded from the instrument) from the subsequent notification which updates all batches. Instead, the particular Experiment/Instrument tab where the request was made restores its own defaults itself.
      
      Re #28429
      3c888dd8
    • Gemma Guest's avatar
      Fix a bug where adding a new batch overwrites other batches · 2b5209e4
      Gemma Guest authored
      The problem here was that when the instrument is set on the new batch, a notification is sent that the instrument has changed and all batches were being reset. However, although the instrument has been set, we can just check whether it is different to the current instrument to check whether it really has changed, and if not, do not do the updates.
      
      Re #28429
      2b5209e4
    • Gemma Guest's avatar
      Update release notes with save/load settings fix · e706548a
      Gemma Guest authored
      Re #28429
      e706548a
    • Gemma Guest's avatar
      Improve batch decoder tests · b0f4592d
      Gemma Guest authored
      The original test json string contained largely default/empty values so it is hard to tell whether they are really being loaded. Add a new string containing fully populated values as well as an "empty" batch representation containing defaults. Use these for the main window containing two batches.
      
      Add a new unit test to test the case where the instrument has changed.
      
      Re #28429
      b0f4592d
  2. Mar 26, 2020
  3. Mar 25, 2020
  4. Mar 24, 2020
  5. Mar 23, 2020
Loading