Clicking restore-defaults on an Experiment or Instrument tab in a batch should only affect that tab and batch. This commit fixes a bug where a notification was sent to all batches, and every Experiment and Instrument tab was being reset. The fix is to separate updating the instrument (which is required to ensure we have up-to-date settings loaded from the instrument) from the subsequent notification which updates all batches. Instead, the particular Experiment/Instrument tab where the request was made restores its own defaults itself.

Re #28429

The problem here was that when the instrument is set on the new batch, a notification is sent that the instrument has changed and all batches were being reset. However, although the instrument has been set, we can just check whether it is different to the current instrument to check whether it really has changed, and if not, do not do the updates.

Re #28429

Also updated class_maker.py

Add a separate method for opening the save/load dialog. Previously it
was always opening the save dialog to get the filename.

Re #27242

- Move the QFileDialog implementation into the view so that the
presenter does not need to know about it. Call the dialog functions via
the IMessageHandler interface.
- Move the save/load JSON functions into the view. Call them via a new
IFileHandler interface. Note that not all Qt types are removed from the
view's interface yet so a TODO has been added.

Re #27242

The reflectometry GUI sets the default instrument in the config service
when it starts up to one of the ISIS reflectometers. This commit adds a
check that the facility is ISIS and if not it sets the facility to ISIS.
This avoids confusion where you essentially have invalid config. It also
avoids confusion where e.g. loading runs from the default archive might
not work because the archive may be a different facility.

I have also added code to save the new config settings to file. Again
this is to avoid confusion between what users see in mantid and what is
in the saved settings. It is particularly confusing otherwise because
Workbench will write settings to file when it closes but MantidPlot will not.

Re #27241

Re #27178

Re #27178

Co-Authored-By: Gemma Guest <gemma.guest@stfc.ac.uk>

Re #27178

Re #27178

Re #27224

Re #27178

Re #26533

Also includes some minor refactoring of tests which require an
instrument to be set to construct the instrument directly in the test
rather than call a notification function which causes the instrument to
be loaded from the name.

Re #26533

Re #26533

Add menu items for showing the Options dialog and the Slit Calculator
tool.

Re #26533

Coordinate via the main window to disable the instrument drop-down box
on all Batch tabs if any batch is processing or autoprocessing.

Re #26536

Make these clearer that they are notify functions

Re #26536

Use clearer names to indicate a notification of a request, a function that performs the action, and a notification
of a result from that action.

Re #26536

Re #26536

This is no longer necessary now that the instrument is stored in and set
by the main window

Re #26536

Setting initial state is done by the main window after adding a new
batch is complete and all presenters know their parent presenter. Move
the initialisation of the instrument list to the same place.

Re #26536

The instrument has been moved to the main window so that it can be
synchronised between batches

Re #26536

Force the compiler to generate the move constructor/assignment operator.
These are no longer implicitly declared since the addition of the
user-declared destructor. Also delete the copy constructor/assignment
operator as these are illegal operations.

Re #26498

This causes a compile error unless the destructor is defined in the cpp file (see the comments on PR #26510)

Re #26498

This commit fixes a couple of incorrect function calls but note that this doesn't actually affect the functionality at the moment because at the moment both of these notifications just cause the widget state to be updated. This commit fixes the new unit tests that have been added, though.

Re #26498

Add an interface to the BatchPresenterFactory.

Re #26498

Recent changes mean the classes now have shorter names so the namespace ensures will will not have any clashes with other GUIs.

Re #26535

These functions, includes and namespaces are no longer used. There should be no references to the DataProcessorWidget anywhere in the new GUI

Re #26025

Re #26025

Re #26025

Add methods to coordinate via main window so that only one autoprocessing process can be running at a time

Re #26025

The interfaces are being simplified such that running python code from the main window presenter will no longer be required.

Re #23027

This contains the reduction configuration for a batch.
It currently uses default models created by the presenter factories, but eventually we will inject the models from the main window presenter containing defaults based on the reduction algorithm