Skip to content
Snippets Groups Projects
  1. Aug 14, 2015
  2. Jul 27, 2015
    • Arseny Kapoulkine's avatar
      Fix two UB sanitizer false positives · f738675f
      Arseny Kapoulkine authored
      Change the expression to reference the array element indirectly. The memory
      block can be bigger than the structure so it's invalid to use static data[]
      size for bounds checking.
      f738675f
  3. Jul 25, 2015
    • Arseny Kapoulkine's avatar
      XPath: Increase memory block alignment to 8 bytes · bd7a8fa4
      Arseny Kapoulkine authored
      To be more precise, the memory block is now aligned to be able to reliably
      allocate objects with both double and pointer fields. If there is a platform
      with a 4-byte double and a 4-byte pointer, the memory block alignment there will
      stay the same after this change.
      
      Fixes #48.
      bd7a8fa4
    • Arseny Kapoulkine's avatar
      tests: Fix test allocator to provide fundamental alignment · e8fdd130
      Arseny Kapoulkine authored
      Previously test allocator only guaranteed alignment enough for a pointer.
      
      On some platforms (e.g. SPARC) double has to be aligned to 8 bytes but pointers
      can have a size of 4 bytes. This commit increases allocation header to fix that.
      
      In practical terms the allocation header is now always 8 bytes.
      e8fdd130
    • Arseny Kapoulkine's avatar
      XPath: Refactor block allocation · 66f242a4
      Arseny Kapoulkine authored
      Extract memory page size and block alignment into named constants.
      66f242a4
    • Arseny Kapoulkine's avatar
      tests: Only enable page heap on x86/x64 · a562bf6d
      Arseny Kapoulkine authored
      This fixes tests in PUGIXML_NO_XPATH mode on SPARC64 (#48).
      
      SPARC does not allow unaligned accesses - e.g. you can't read an unaligned int.
      Normally pugixml does not perform unaligned integer/pointer accesses, but page
      heap can allocate blocks that are not aligned so that we can detect a single-
      byte read/write overrun.
      
      Additionally, the hardcoded page size we're currently using is really system
      specific - on SPARC the page size can be 8 Kb instead of 4 Kb so mprotect can
      fail.
      a562bf6d
  4. Jul 23, 2015
  5. Jun 24, 2015
  6. Jun 13, 2015
    • Arseny Kapoulkine's avatar
      Makefile now supports Xcode 7 ASAN · 238b786b
      Arseny Kapoulkine authored
      All other sanitizers are still unavailable so only enable them on non-OSX
      systems.
      238b786b
    • Arseny Kapoulkine's avatar
      Fix Clang 3.7 compatibility · d04df2a4
      Arseny Kapoulkine authored
      Apparently Clang 3.7 implements C++ DR 1748 that makes placement new with null
      pointer undefined behavior. Which renders all C++ programs that rely on this
      invalid. Which includes pugixml.
      
      This is not very likely to happen in the wild because the allocations that are
      subject to this in pugixml are relatively small, but tests break because of
      this.
      
      Fix the issue by adding null pointer checks (that are completely redundant in
      all current compilers except Clang 3.7 but it's not like there is another
      option).
      d04df2a4
  7. May 23, 2015
  8. May 22, 2015
  9. May 20, 2015
  10. May 14, 2015
    • Arseny Kapoulkine's avatar
      Implement xml_node::attribute with a hint · f828eae3
      Arseny Kapoulkine authored
      Extra argument 'hint' is used to start the attribute lookup; if the attribute
      is not found the lookup is restarted from the beginning of the attriubte list.
      
      This allows to optimize attribute lookups if you need to get many attributes
      from the node and can make assumptions about the likely ordering. The code is
      correct regardless of the order, but it is faster than using vanilla lookups
      if the order matches the calling order.
      
      Fixes #30.
      f828eae3
  11. May 13, 2015
  12. May 04, 2015
  13. May 03, 2015
    • Arseny Kapoulkine's avatar
      Merge pull request #42 from zeux/compact · 873c8e50
      Arseny Kapoulkine authored
      Implement compact mode.
      
      This introduces a new storage mode that dramatically reduces node size at some performance cost.
      The mode is enabled by defining PUGIXML_COMPACT. This does not change API/ABI - all existing functionality still works.
      
      The pointers are stored using delta encoding and bytes, with some additional tricks to make encoding more optimal for e.g. parent pointer and string pointers. Since the node is fixed size, we have to fall back to a hash table if the pointer does not fit. Thus all DOM operations still have amortized complexity - constant number of operations if you don't need the hash table and amortized constant if you do.
      
      Aside from some performance loss (which is inevitable since decoding takes time), the only other caveat is that we can't remove entries from the hash table - so in some edge cases with a lot of node removals the peak memory consumption can grow indefinitely. In theory we can implement this later; it's unclear that this is useful at this point.
      
      The resulting node/attribute sizes are as follows:
      non-compact node: 28b 32-bit, 56b 64-bit
      compact node: 12b 32/64-bit
      non-compact attribute: 20b 32-bit, 40b 64-bit
      compact attribute: 8b 32/64-bit
      873c8e50
    • Arseny Kapoulkine's avatar
      Cleanup before merge · 9597265a
      Arseny Kapoulkine authored
      9597265a
    • Arseny Kapoulkine's avatar
      Fix MSVC warning · b1965061
      Arseny Kapoulkine authored
      b1965061
  14. May 02, 2015
Loading