Use () instead of {} for initialization in constructors

Using {} syntax for direct initialization of reference types in constructor
member initialization lists is broken on some compilers, even though it's valid
C++11 code.  Use () to ensure correctness.

include/engine/bp/BPFileWriter.h

@@ -34,9 +34,9 @@ public:
    * @param method
    * @param debugMode
    */
-  BPFileWriter(ADIOS &adios, std::string name,
-               const std::string &accessMode, MPI_Comm mpiComm,
-               const Method &method, const IOMode iomode = IOMode::INDEPENDENT,
+  BPFileWriter(ADIOS &adios, std::string name, const std::string &accessMode,
+               MPI_Comm mpiComm, const Method &method,
+               const IOMode iomode = IOMode::INDEPENDENT,
                const float timeout_sec = 0., const bool debugMode = false,
                const unsigned int nthreads = 1);
 

source/core/Engine.cpp

@@ -20,10 +20,10 @@ namespace adios
 Engine::Engine(ADIOS &adios, std::string engineType, std::string name,
                std::string accessMode, MPI_Comm mpiComm, const Method &method,
                bool debugMode, unsigned int nthreads, std::string endMessage)
-: m_MPIComm{mpiComm}, m_EngineType{std::move(engineType)},
-  m_Name{std::move(name)}, m_AccessMode{std::move(accessMode)},
-  m_Method{method}, m_ADIOS{adios}, m_DebugMode{debugMode},
-  m_nThreads{nthreads}, m_EndMessage{std::move(endMessage)}
+: m_MPIComm(mpiComm), m_EngineType(std::move(engineType)),
+  m_Name(std::move(name)), m_AccessMode(std::move(accessMode)),
+  m_Method(method), m_ADIOS(adios), m_DebugMode(debugMode),
+  m_nThreads(nthreads), m_EndMessage(std::move(endMessage))
 {
   if (m_DebugMode == true)
   {

source/engine/bp/BPFileWriter.cpp

@@ -9,8 +9,8 @@
  */
 #include <utility>
 
-#include "engine/bp/BPFileWriter.h"
 #include "ADIOS.h"
+#include "engine/bp/BPFileWriter.h"
 
 // supported transports
 #include "transport/file/FStream.h"
@@ -25,12 +25,12 @@ BPFileWriter::BPFileWriter(ADIOS &adios, std::string name,
                            const Method &method, const IOMode /*iomode*/,
                            const float /*timeout_sec*/, const bool debugMode,
                            const unsigned int nthreads)
-: Engine{adios, "BPFileWriter", std::move(name), accessMode, mpiComm, method,
+: Engine(adios, "BPFileWriter", std::move(name), accessMode, mpiComm, method,
          debugMode, nthreads,
-         " BPFileWriter constructor (or call to ADIOS Open).\n"},
-  m_Buffer{capsule::STLVector{accessMode, m_RankMPI, m_DebugMod}},
-  m_BP1Aggregator{format::BP1Aggregator(m_MPIComm, debugMode)},
-  m_MaxBufferSize{m_Buffer.m_Data.max_size()}
+         " BPFileWriter constructor (or call to ADIOS Open).\n"),
+  m_Buffer(accessMode, m_RankMPI, m_DebugMode),
+  m_BP1Aggregator(m_MPIComm, debugMode),
+  m_MaxBufferSize(m_Buffer.m_Data.max_size())
 {
   m_MetadataSet.TimeStep = 1; // starting at one to be compatible with ADIOS1.x
   Init();