Fix clang-tidy issues in STLVector

include/capsule/heap/STLVector.h

@@ -40,10 +40,9 @@ public:
    * @param rankMPI MPI rank
    * @param debugMode true: extra checks, slower
    */
-  STLVector(const std::string accessMode, const int rankMPI,
-            const bool debugMode = false);
+  STLVector(std::string accessMode, int rankMPI, bool debugMode = false);
 
-  ~STLVector();
+  ~STLVector() = default;
 
   char *GetData();
   char *GetMetadata();

source/capsule/heap/STLVector.cpp

@@ -20,15 +20,12 @@ namespace adios
 namespace capsule
 {
 
-STLVector::STLVector(const std::string accessMode, const int rankMPI,
-                     const bool debugMode)
-    : Capsule("Heap", accessMode, rankMPI, debugMode)
+STLVector::STLVector(std::string accessMode, int rankMPI, bool debugMode)
+: Capsule{"Heap", std::move(accessMode), rankMPI, debugMode}
 {
   m_Data.reserve(16777216);
 }
 
-STLVector::~STLVector() {}
-
 char *STLVector::GetData() { return m_Data.data(); }
 
 char *STLVector::GetMetadata() { return m_Metadata.data(); }
@@ -79,5 +76,5 @@ void STLVector::ResizeMetadata(const std::size_t size)
   }
 }
 
-} // end namespace heap
-} // end namespace
+} // end namespace capsule
+} // end namespace adios