From 4c3fb32011f4a00ad6548b174830eb49ddf1bdd8 Mon Sep 17 00:00:00 2001
From: Chuck Atkins <chuck.atkins@kitware.com>
Date: Sat, 1 Apr 2017 20:04:54 -0400
Subject: [PATCH] Fix clang-tidy issues in STLVector
---
include/capsule/heap/STLVector.h | 5 ++---
source/capsule/heap/STLVector.cpp | 11 ++++-------
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/include/capsule/heap/STLVector.h b/include/capsule/heap/STLVector.h
index bd8104e8b..b548a64d6 100644
--- a/include/capsule/heap/STLVector.h
+++ b/include/capsule/heap/STLVector.h
@@ -40,10 +40,9 @@ public:
* @param rankMPI MPI rank
* @param debugMode true: extra checks, slower
*/
- STLVector(const std::string accessMode, const int rankMPI,
- const bool debugMode = false);
+ STLVector(std::string accessMode, int rankMPI, bool debugMode = false);
- ~STLVector();
+ ~STLVector() = default;
char *GetData();
char *GetMetadata();
diff --git a/source/capsule/heap/STLVector.cpp b/source/capsule/heap/STLVector.cpp
index b6f12dbdc..03564095e 100644
--- a/source/capsule/heap/STLVector.cpp
+++ b/source/capsule/heap/STLVector.cpp
@@ -20,15 +20,12 @@ namespace adios
namespace capsule
{
-STLVector::STLVector(const std::string accessMode, const int rankMPI,
- const bool debugMode)
- : Capsule("Heap", accessMode, rankMPI, debugMode)
+STLVector::STLVector(std::string accessMode, int rankMPI, bool debugMode)
+: Capsule{"Heap", std::move(accessMode), rankMPI, debugMode}
{
m_Data.reserve(16777216);
}
-STLVector::~STLVector() {}
-
char *STLVector::GetData() { return m_Data.data(); }
char *STLVector::GetMetadata() { return m_Metadata.data(); }
@@ -79,5 +76,5 @@ void STLVector::ResizeMetadata(const std::size_t size)
}
}
-} // end namespace heap
-} // end namespace
+} // end namespace capsule
+} // end namespace adios
--
GitLab