Skip to content

Clean up stitching code

Duggan, John requested to merge 36-clean-up-stitching-code into main

Summary of Changes

  1. Downgrades altair package to get it to produce vega-lite schemas with versions that match trame-vega's. This should remove the warning spam on the stitching tab.
  2. Added back a missing stitching trigger that is needed when the user hand edits stitching values and ensures that hand-edited values are properly converted into floats.
  3. Cleans up the prerendering step and simplifies the logic for it. Basically, I am now prerendering all of the figures "in place" rather than in a separate div, and I've removed the accompanying JS code that was moving the figures back and forth from that separate div.

Checklist

  • The MR has a clear and concise title
  • Code is self-documented and follows style guidelines.
  • Automated tests are written and pass successfully.
  • Regression tests (e.g. manually triggered system tests, manual GUI/tool tests, ...) are performed to make sure the MR does not break anything (when applicable)
  • Readme file is present and up-to-date.

Documentation Updates

Additional Notes

Closes #36 (closed)

Merge request reports