Skip to content

Update the stitching handlers in all appropriate locations

I found two related bugs while looking into this.

  1. Vega event listeners were being removed if you toggled log-scale axes or modified the selected q-ranges.
  2. Deleting and then re-adding an overlap was causing the event listeners to be removed and causing plots to render incorrectly because the vega.Figure reference was being lost.

I think that how these event listeners are set up is still extremely error-prone (meaning there may be other things that cause this to happen that I'm unaware of right now). I think that ndip/public-packages/trame-facade#15 (closed) should make this kind of interactivity easier to setup/more robust going forward, but that will take longer to set up and test so I wanted to fix this as well as I know how in the interim.

Closes #35 (closed)

Edited by Duggan, John

Merge request reports