Skip to content

Bump trame-facade to reenable window transitions

Duggan, John requested to merge 18-resizeobserver-error into main

Transitioning to the "Advanced Settings" tab would cause a ResizeObserver error because of a few issues interacting with one another:

  1. When a window is loaded after clicking a tab, its page content will be rendered which causes the page content to resize.
  2. We've set the page scrollbar to only render if necessary, so page content will resize again if the new window is large enough to need a scrollbar.

Without transitions, point 2 happens during the handling of point 1, which causes the ResizeObserver error. I've added transitions back (but made them fade instead of slide transitions which I think is a bit nicer and will address the reason we removed the transitions in the first place.

Closes #18 (closed)

Merge request reports