Skip to content

Disable batch and colletion form inputs for repated input forms

Cage, Gregory requested to merge 120-disable-incorrect-input-types into dev

Summary of Changes

This mr disables collection and batch form inputs for tools that allow you to "insert" datasets by clicking an insert button. This is because the insertion itself is what allows users to add multiple files as inputs, and thus the other two ways are unnecessary and confusing.

Checklist

  • The MR has a clear and concise title
  • Code is self-documented and follows style guidelines.
  • Automated tests are written and pass successfully.
  • Regression tests (e.g. manually triggered system tests, manual GUI/tool tests, ...) are performed to make sure the MR does not break anything (when applicable)
  • Readme file is present and up-to-date.

Documentation Updates

Additional Notes

In order to test with a default set of tools in Galaxy: Clone the repository (make sure on dev branch) -> navigate to the top level path of the project -> Execute the run.sh script. In the tool panel on the left, select the Graph/Display Data tool section, and then select the VCF to MAF Custom Track tool. In this tool, you have the option to add datasets as inputs by clicking the "insert" button. The inputs should have this type of input selection beside them:

Screenshot_2024-09-23_at_10-52-04_Galaxy

Now, checkout this branch (120-disable-incorrect-input-types). Re-run Galaxy using run.sh. Select the VCF to MAF Custom Track tool again. Now, the multiple datasets and dataset collection input options should be gone:

Screenshot_2024-09-23_at_10-57-00_Galaxy

If you navigate to a tool that has an input, but does not let you insert datasets, the input selection should be the same as the default dev branch (with all options available). You can find examples under the Convert Formats tool section.

Now in order to make sure the functionality works, click on the Upload button on the left, and select more than one file (preferably text) to upload using the upload dialog (make sure to hit the "Finish" button to actually upload). Now, in the tool panel, in the Text Manipulation section, select the Concatenate Datasets tool. For the first input, you can select any of your uploaded datasets that are in your history. Now, click on the "Insert Dataset" button. While the first input dialog will have all the three options available (this is intended behavior with the current acceptance criteria), the inserted dataset should only have the one type available (single dataset). You can choose another dataset for this input. Continue adding as many datasets as you desire, and then run the tool using the "Run Tool" button in the top right. The job should successfully execute.

Closes #120 (closed)

Edited by Cage, Gregory

Merge request reports