Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/mantidproject/mantid.git. Pull mirroring updated .
  1. Mar 31, 2020
  2. Mar 26, 2020
  3. Mar 25, 2020
  4. Mar 24, 2020
  5. Mar 23, 2020
  6. Mar 20, 2020
  7. Mar 16, 2020
    • Danny Hindson's avatar
      Further work on applying cmake GenerateExportHeader · a8c3109c
      Danny Hindson authored
      Apply change to insert export macros into class definition using cmake GenerateExportHeader
      feature to 3 more projects: API, Crystal and CurveFitting
      Have replaced DllExport with the cmake macro except in these places:
      
      a) class templates - the definitions of class template member functions need to be in the
      same unit as the declaration so dllimport gives a compilation error in the client code
      (C2491 in VS) eg SingleValueParameter, SingleValueParameterParser
      b) headers which are in a project but aren't included by any .cpp units in the project
      eg IBackgroundFunction.h, ICatalogInfoService.h. In these cases I've removed the DLLExport
      attribute completely
      
      For the API target there were a couple of special cases\extras:
      
      API has some conditional use of the extern keyword to control instantiation of template
      classes. This has been inserted into the automatically created dllconfig.h using a cmake
      switch that allows some custom content to be appended to the end of the file. Few of the
      targets require this so I've added a boolean parameter to the wrapper function to handle
      this GENERATE_MANTID_EXPORT_HEADER
      
      I also had to add explicit include directories to PythonInterfaceCore where it imports an
      API target header (in the unit ExtractWorkspace.h) without having API as a dependency
      a8c3109c
  8. Mar 13, 2020
  9. Mar 10, 2020
  10. Mar 09, 2020
  11. Mar 06, 2020
  12. Mar 05, 2020
    • Harriet Brown's avatar
      Remove header guards from tcc files in API · c7347d33
      Harriet Brown authored
      This commit removes header guards from tcc files that was missed in search script
      c7347d33
    • Danny Hindson's avatar
      Fix problems with setting YErr columns on table workspace · 77b9c037
      Danny Hindson authored
      This change fixes a problem in Workbench when setting columns to YErr
      Previously this only worked if all Y columns had an associated YErr column. If that
      wasn't the case then the associations between Y and YErr cols got mixed up
      I have saved the link between the YErr and Y column into the C++ table workspace
      object via changes to ITableWorkspace and the Column class
      I've also modified the model\view\presenter for the table workspace to set and get
      the link via the ITableWorkspace interface
      The code in marked_columns.py has been modified to remove the _add function because
      the logic required for adding x, y and yerr was sufficiently different that trying
      to push them through a common _add function was obscuring the code
      Finally I've removed the labelindex from the ErrorColumn object in the python code
      because it can be worked out on the fly (and I didn't want to have to save this also
      into the C++ table workspace in addition to the linked column index)
      
      As part of the test updates I have removed the test
      TableWorkspaceDisplayModelTest.test_initialise_marked_columns_yerr_before_y_doesnt_mark_yerr
      because we do require the ability to add a yerr column before the corresponding y column
      The model gets refreshed whenever the C++ table workspace is updated (eg when the type of a column
      is updated) as part of a replace_workspace call. The model __init__ function builds up the column
      set left to right and a user may have set up a Y err column which is to the left of the corresponding
      Y column.
      77b9c037
    • mantid-builder's avatar
      clang-format PR28233 123d8782 · 5d34f7bf
      mantid-builder authored
      
      Signed-off-by: default avatarHarriet Brown <harriet.brown@stfc.ac.uk>
      5d34f7bf
    • Harriet Brown's avatar
      Repalce header guards in API with pragma once · 123d8782
      Harriet Brown authored
      This commit replaces all header guards in API with #pragma once
      123d8782
  13. Mar 04, 2020
  14. Jan 31, 2020
  15. Jan 16, 2020
  16. Jan 09, 2020
  17. Dec 18, 2019
  18. Dec 14, 2019
  19. Dec 13, 2019
  20. Dec 04, 2019
Loading