Giovanni Di Siena authored 4 years ago and Gigg, Martyn Anthony committed 4 years ago

In places other substitutions have been made, e.g
Clang does not yet specialize std::shared_ptr for T[]. Vector
has been used instead. The operator[] methods were incorrectly
marked const but returning a non-const reference - this has been fixed.
Refs #25842

Re #27826

This Commit fixes failing system tests in ISIS powder polaris.

re: #28415

Creates new tab names correctly on non-GNOME enrionvments for Ubuntu.
KDE automatically binds keyboard shortcuts, which Qt represents with &x
(where x is the shortcut). This breaks the name lookup as &New != New in
"New Tab".

We now strip out these characters when looking up the names fixing the
names not incrementing correctly.

Clicking restore-defaults on an Experiment or Instrument tab in a batch should only affect that tab and batch. This commit fixes a bug where a notification was sent to all batches, and every Experiment and Instrument tab was being reset. The fix is to separate updating the instrument (which is required to ensure we have up-to-date settings loaded from the instrument) from the subsequent notification which updates all batches. Instead, the particular Experiment/Instrument tab where the request was made restores its own defaults itself.

Re #28429

The problem here was that when the instrument is set on the new batch, a notification is sent that the instrument has changed and all batches were being reset. However, although the instrument has been set, we can just check whether it is different to the current instrument to check whether it really has changed, and if not, do not do the updates.

Re #28429

Re #28429

This commit adds the changes to the release notes for the changes to rebinning in polaris create pdf. It also adds the changes to the script documentation.

Removes all of the from __future__ imports that open and close the
brackets on the same line. This is most of them.

Miscellaneous code review comments to add comments, remove redundant brackets
Also added comment to the sample environment concept page to explain where
Mantid will search for the attenuation profile file

This commit adds release notes detailing the change of output names from Polaris.create_total_scattering_pdf

re: #28414

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

While the primary use of the new attenuation profile file feature is expected
to be via the sample environment xml file, it also makes sense to add it into
any algorithms where the material properties can be specified. So I've added a
new attenuation profile parameter to the SetSampleMaterial and LoadSampleEnvironment
algorithms. The validations on these algorithms means they can't be called using
postional arguments so have inserted the new parameter in the logical place next
to the absorption cross section

Have updated the docs to explain how the attenuation profile file is used

Change absolute to absorption in comment against cross section types
Clarify formula in Materials concept page

First checking, more to save state over the weekend

Also updated class_maker.py

cmake add_custom_command is only run if any of the listed outputs is missing
or if any of the dependencies are out of date. If any of the documentation
.rst files is changed this didn't cause the custom command to run.
I've changed this so the command always runs by adding an extra dummy output
file that doesn't ever get created. The sphinx builder has some incremental
build functionality inside it so this will identify whether any .rst files
have changed
Note - I also had to set the cmake source file property to SYMBOLIC to avoid the
following Visual Studio warning which was added in Visual Studio 2019 (v16.4):

warning MSB8065: Custom build for item XXXX succeeded, but specified output
"c:\mantid\build\docs\dummyoutput_alwaysrun" has not been created. This may cause
 incremental build to work incorrectly.

The sphinx.util.logging framework was not available
in version 1.2 that is currently used by RHEL 7. This wraps
the calls and chooses an appropriate implementation.

Co-Authored-By: Harrietbrown <49688535+Harrietbrown@users.noreply.github.com>

They have low to zero usage and at this point are
just a maintenance burden. They do not work in
workbench and are not worth the effort to port.
In the future it would be better to replace input
in workbench with a function that raises a generic
QInputDialog.

This includes docs for ThermalNeutronBk2BkExpAlpha, ThermalNeutronBk2BkExpBeta, ThermalNeutronBk2BkExpSigma and ThermalNeutronDtoTOFFunction