Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/mantidproject/mantid.git. Pull mirroring updated .
  1. May 10, 2018
  2. May 09, 2018
  3. May 08, 2018
  4. May 04, 2018
  5. May 03, 2018
    • Edward Brown's avatar
      Exposed RowLocation operators through SIP. · 1c9049a0
      Edward Brown authored
      - Moved call to enableFiltering into constructor of JobTreeView.
      - Exposed the RowLocation operators through SIP by making them member
        functions.
      - Should do as above for Row and Cell in later commits.
      
      Re #22263
      1c9049a0
    • Edward Brown's avatar
      Implemented resetFilter signal and did some more tidying. · 9ade3ae7
      Edward Brown authored
      - Added notifyResetFilter, called whenever the filter is reset by the
        view.
      - Renamed borderTransparency to borderOpacity to better reflect the
        fact that a borderTransparency of 0 is fully transparent.
      - Reimplemented RegexFilter in a more flexible and consise way.
      
      Re #22263
      9ade3ae7
  6. May 02, 2018
    • Edward Brown's avatar
      Added ability to set background colour, border and icon per-cell. · 1ec1c8bd
      Edward Brown authored
      - Added the aforementioned properties to the Cell class.
      - Added mechanics to CellStandardItem functions to extract and apply
        these properties.
      - Fixed a bug in RowLocationAdapter whereby rows on the path were
        required to have at least as many columns as the column of the index
        being fetched.
      - Exposed this new functionality to python
      - Experimented with these properties in batch_widget_gui.py
      
      Re #22263
      1ec1c8bd
    • Edward Brown's avatar
      Tidied up QtStandardItemTreeAdapter. · 8283e1e0
      Edward Brown authored
      - Fixed copy-paste border colour problem.
        - Made transparency stored separately from the colour in the Cell class.
      - Moved padding functionality into C++ JobTreeView will now pad rows
        shorter than the model column count with 'dead' cells.
      
      Re #22263
      8283e1e0
  7. May 01, 2018
    • Edward Brown's avatar
      Tidied up Cell implementation. · d24bf4d4
      Edward Brown authored
      - Moved methods for operating on QStandardItem/Cell objects + custom role
        enum to CellStandardItem.h/cpp.
      - Increased CellDelegate's awareness of custom roles.
      - Changed storage-duration of QtFilterLeafNodes to automatic.
      - Used new functionality to perform padding of group rows - this
        functionality should be moved into JobTreeView in a later commit.
      
      Re #22263
      d24bf4d4
    • Edward Brown's avatar
      Partially replaces std::string with Cell class. · f6707177
      Edward Brown authored
      - Added Cell class to store the modifiable cell properties aside from the text e.g.
        borderThickness, isEditable.
      - Replaced usages of std::string in place of cell in JobTreeView and
        QtStandardItemTreeAdapter functions.
      - Adjusted BuildSubtrees to account for this.
      - Started implementing some of the updated api for
        QtStandardItemTreeAdapter.
      
      Re #22263
      f6707177
    • Edward Brown's avatar
      Completed work for adding filtering. Started cleaning up for PR. · 7b95b167
      Edward Brown authored
      - Used QtFilterLeafNodes as a proxy model over the real model.
      - Added strongly typed QModelIndexes based on StrictModelIndex template.
      - Added methods and refactored code to handle conversions between
        different model index spaces correctly - strict QModelIndex classes
        help to enforce this.
      - Refactored QtStandardItemTreeAdapter to be a set of methods rather
        than a class - a different logical grouping may follow.
      - Added filterRowsBy methods to set the filter predicate and
        resetFilter method to switch to a true-predicate.
      - Exposed this filtering functionality to python.
      - Split QtTreeCursorNavigation into additional header QtBasicNavigation.
      - Moved RowLocation -> QModelIndex and QModelIndex -> RowLocation
        conversion logic into RowLocationAdapter class to allow re-use in other
        contexts such as QtFilterLeafNodes.
      7b95b167
  8. Apr 26, 2018
    • Edward Brown's avatar
      Added python bindings and polished JobTreeView API. · 3573e478
      Edward Brown authored
      - Added BuildSubtreeTest - a replacement for the messy version in JobTreeView.
      - Added additional methods for dealing with Subtree objects.
      - Modified interface of the copy and paste signals presenters must now
        get selection explicitly.
      - Exposed Row class to python.
      
      Re #22263
      3573e478
    • Edward Brown's avatar
      Started to use ExtractSubtrees and FindRootNodes. · c6779204
      Edward Brown authored
      Updated implementation of replaceRows.
      
      Re #22263
      c6779204
    • Edward Brown's avatar
    • Edward Brown's avatar
      Implemented row insertion notification. · 7bc7033e
      Edward Brown authored
      This required making JobTreeView aware of the editor status.
      When a presenter is notified of a row insertion it needs to be able
      to remove the inserted row if the row is greater than the maximum
      depth for example.
      
      However after inserting a new row we natuarally open the editor at it
      and set it as the current index. If you try to remove the row while
      it is the current index and the editor is open then the row is
      silently not removed.
      
      Before attempting to remove the row we try detect if the removal would
      be inefective and if so, shift the current index somewhere else, if t
      here is nowhere else to move it then we thow an exception.
      
      This commit therefore makes it impossible to delete all rows,
      something we may need to fix in a future commit.
      
      Re #22263
      7bc7033e
    • Edward Brown's avatar
      Added CellDelagate to provide cell outlines. · ded1511f
      Edward Brown authored
      - Added a QStyledItemDelagate.
      - Created and set inside JobTreeView.
      
      Re #22263
      ded1511f
  9. Apr 12, 2018
    • Edward Brown's avatar
      Implement edit, copy and insert notifications. · ae9d0495
      Edward Brown authored
      - Track last edited cell + overload commitData to enable user
        updates to be distinguished from presenter updates and only
        dish out notifications for the former.
      - Add copy notification method to JobTreeViewSubscriber interface.
      - Add new signal to JobTreeViewSignalAdapter.
      - Update SIP bindings.
      - Add and expose depth() method on RowLocation.
      
      Re #22263
      ae9d0495
    • Edward Brown's avatar
      Allow RowLocation in signal parameters. Implement cell text accessors · d346912c
      Edward Brown authored
      - Added default constructor.
      - Registered type using qMetaType.
      - Added support methods to TreeAdapter.
      - Implemented textAt, rowTextAt, setCellText etc.
      
      Re #22263
      d346912c
  10. Apr 11, 2018
    • Edward Brown's avatar
      Implemented multi-row removal. · 7008b170
      Edward Brown authored
      - Added delete key to trigger removal.
      - Added operators to RowLocation to enable sorting + future unit
      testing.
      - Renamed methods in JobTreeView subscriber interface.
      - Used RowLocation lexicographical sorting to enable safe-multidelete.
      - Fixed infinate loop in implementation of rowLocationAt.
      
      Re #22263
      7008b170
  11. Apr 10, 2018
    • Edward Brown's avatar
      Added modified JobTreeView from batch_widget_prototype. · ff50cce8
      Edward Brown authored
      - Added a modified version of JobTreeView from the
        batch_widget_prototype branch
      - Refactored out QtStandardItemTreeAdapter which can be tested
        separately from the view.
      - Also transfered QtTreeCursorNavigation, the class used to implement
        the tab based navigation.
      
      Re #22263
      ff50cce8
Loading