Skip to content
Snippets Groups Projects

Use MPI_Comm_dup to separate ArborX comm context from user's

Merged Use MPI_Comm_dup to separate ArborX comm context from user's
github/fork/aprokop/use_comm_dup into master
Merged Arndt, Daniel requested to merge github/fork/aprokop/use_comm_dup into master

Created by: aprokop

This call should normally not involve any communication.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/ArborX_DistributedSearchTree.hpp
105 105 template <typename Primitives>
106 106 DistributedSearchTree<DeviceType>::DistributedSearchTree(
107 107 MPI_Comm comm, Primitives const &primitives)
108 : _comm(comm)
109 , _bottom_tree(primitives)
108 : _bottom_tree(primitives)
110 109 {
110 MPI_Comm_dup(comm, &_comm);
  • Arndt, Daniel
    Arndt, Daniel @6da ·
    Author Owner

    Created by: dalg24

    You need to comment about the duplication. I do not understand what is different from copying since it duplicate the attributes of the original communicator.

  • Arndt, Daniel
    Arndt, Daniel @6da started a thread on commit 3b8b63bc
    • src/ArborX_DistributedSearchTree.hpp
    105 105 template <typename Primitives>
    106 106 DistributedSearchTree<DeviceType>::DistributedSearchTree(
    107 107 MPI_Comm comm, Primitives const &primitives)
    108 : _comm(comm)
    109 , _bottom_tree(primitives)
    108 : _bottom_tree(primitives)
    110 109 {
    110 MPI_Comm_dup(comm, &_comm);
    • Arndt, Daniel
      Arndt, Daniel @6da ·
      Author Owner

      Created by: aprokop

      Copying communicator does not create new context. Duplicating does. Having a different context means that the messages sent by user cannot be received by the library and vice versa, even if they have the exact same information and tags.

  • Arndt, Daniel
    Arndt, Daniel @6da started a thread on commit 3b8b63bc
    • src/ArborX_DistributedSearchTree.hpp
    105 105 template <typename Primitives>
    106 106 DistributedSearchTree<DeviceType>::DistributedSearchTree(
    107 107 MPI_Comm comm, Primitives const &primitives)
    108 : _comm(comm)
    109 , _bottom_tree(primitives)
    108 : _bottom_tree(primitives)
    110 109 {
    110 MPI_Comm_dup(comm, &_comm);
    Please register or sign in to reply