Skip to content
Snippets Groups Projects

Mace3D improvement

Merged Mace3D improvement
mace3D_improvement into master
Merged Yang, Diyu requested to merge mace3D_improvement into master

Created by: dyang37

This PR is mostly handling issue #65 (closed) and #66 (closed). This PR contains improvements to mace3D demo scripts as well as mace functionality:

  1. Remove keras denoiser from mace3D demo scripts.
  2. In mace3D demo scripts, explicitly perform a qGGMRF recon. Previously this was done by loading the numpy array that contains qGGMRF recon, where the array is saved by mace3D function when computing qGGMRF as an init image.
  3. Remove os operations in mace functions: In mace3D and 4D we no longer write any files to disk.
  4. In mace3D and mace4D, change qGGMRF sharpness to be the same as MACE sharpness.
  5. Some optimization to mace4D dask variable initialization. We only initialize dask variables when a cluster_ticket is provided.
  6. Some minor updates on data download function.

Merge request reports

Approval is optional

Merged by avatar (Mar 13, 2025 5:06pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Yang, Diyu
    Yang, Diyu @yang1467 ·
    Author Owner

    Created by: DamonLee5

    Review: Commented

    It seems like you delete save_path in the mace interface. I guess this is because you don't want to use os operation in mace3D.

    I tested your code with two mace demos, it works on my mac.

  • Yang, Diyu
    Yang, Diyu @yang1467 ·
    Author Owner

    Merged by: cabouman at 2022-05-05 18:59:24 UTC

Please register or sign in to reply