[Task] Submit PR for the second stage of implementation
This is our second PR. One thing to always keep in mind is, the starting point of the second PR should be exactly the final version that is merged into neutron/addie master branch in our first PR. When submitting our first PR, there may be some changes needed to address comments from reviewers and we want to make sure the starting point of the second stage implementation does contain all those changes.
-
Once we finish the implementation for solving the following entries listed in #10, we will submit our changes at this stage to ADDIE repository through pull request. The issues needs to be solved at this stage,
7 (#21 (closed)), 3 (#22 (closed)), 6 (#23 (closed)) and 2 (#24 (closed))
-
Check out a new branch in your own git repository and put all the changes implemented in the second stage in place.
-
Run
git diff
to see all the changes -> check through all the changes to make sure they all make sense. -
Run
flake8
on changed files to make sure the format requirement is not broken. -
Push local branch to your own remote git repository.
-
Submit pull request (to ADDIE
master
branch) from GitHub online repository interface.