[Scope] Running list of issues in ADDIE interface

Issues

1. Under Edit tab, selecting "Reset GSAS-tab" causes ADDIE to crash File "/SNS/users/3d0/miniconda3/envs/addie-env_test/lib/python3.6/site-packages/addie/main.py", line 772, in do_reset_gsas_tab calculategr_event_handler.do_reset_gsas_tab(self) AttributeError: module 'addie.calculate_gr.event_handler' has no attribute 'do_reset_gsas_tab' Aborted (core dumped)

2. Under help tab, selecting Cheat Sheet leads to https://neutrons.github.io/addie/index.html, site not found error

3. As previously mentioned Reduction Configuration Refresh button not working

  1. May need to reduce default size of Reduction Configuration or add slider bar, the only way I could see past the global align and focus portion was by using alt + F7 key command, could be unique to my monitor size though

5. When importing from oncat database, selecting Change User button and logging in again causes ADDIE to crash File "/SNS/users/3d0/miniconda3/envs/addie-env_test/lib/python3.6/site-packages/addie/processing/mantid/master_table/import_from_database/oncat_authentication_handler.py", line 111, in ok_clicked self.next_function() TypeError: 'NoneType' object is not callable Aborted (core dumped)

6. Haven't been able to get the search box/button at top of interface to work, don't think it has any functionality

7. Haven't been able to get any result other than Unable to calculate Molecular Mass. CHECK YOUR FORMULA! from periodic table, even retrying formulas loaded in from database

8. If Chemical formula is filled out in table entry, selecting Mass Density and switching to Number Density, trying to replace N/A in field with number causes ADDIE to crash: File "/SNS/users/3d0/miniconda3/envs/addie-env_test/lib/python3.6/site-packages/addie/utilities/math_tools.py", line 196, in number_density2mass_density mass_density = number_density * molecular_mass / natoms / avogadro_term TypeError: unsupported operand type(s) for *: 'float' and 'NoneType' Aborted (core dumped) Another Error With same button: File "/SNS/users/3d0/miniconda3/envs/addie-env_test/lib/python3.6/site-packages/addie/processing/mantid/master_table/mass_density_handler.py", line 194, in number_density_value_changed number_density = np.float(self.ui.number_density_line_edit.text()) ValueError: could not convert string to float: Aborted (core dumped)

  1. Already knew issue existed but Error output when pressing Launch Reduction button is: Traceback (most recent call last): File "/SNS/users/3d0/miniconda3/envs/addie-env_test/lib/python3.6/site-packages/addie/main.py", line 559, in run_mantid mantid_reduction_launcher.run_mantid(self) File "/SNS/users/3d0/miniconda3/envs/addie-env_test/lib/python3.6/site-packages/addie/processing/mantid/launch_reduction.py", line 87, in run_mantid reduction_input = exporter.convert_from_row_to_reduction(json_input) File "/SNS/users/3d0/miniconda3/envs/addie-env_test/lib/python3.6/site-packages/addie/processing/mantid/master_table/master_table_exporter.py", line 649, in convert_from_row_to_reduction element_section) File "/SNS/users/3d0/miniconda3/envs/addie-env_test/lib/python3.6/site-packages/addie/processing/mantid/master_table/master_table_exporter.py", line 505, in density_selection_for_reduction dictionary['MassDensity'] = float(mass_density) ValueError: could not convert string to float: 'N/A' Aborted (core dumped)

  2. Need to put warning for when launch reduction is hit with nothing in table, crashes Addie with error File "/SNS/users/3d0/miniconda3/envs/addie-env_test/lib/python3.6/site-packages/addie/main.py", line 559, in run_mantid mantid_reduction_launcher.run_mantid(self) File "/SNS/users/3d0/miniconda3/envs/addie-env_test/lib/python3.6/site-packages/addie/processing/mantid/launch_reduction.py", line 67, in run_mantid raise RuntimeError('Cannot export empty table') RuntimeError: Cannot export empty table Aborted (core dumped) which is exactly how it should behave right now

11. Sometimes when loading in from database, a second Options to load list of runs selected window is created that cannot be deleted. Hard to pin down the exact cause yet, has happened twice loading in different files. Still can't reliably reproduce Example: image

12. When trying to import from database, during authentication stage, if we click on Cancel button the authentication window will be closed and we are then left with the 'Import from database' window. Then in this window, if we are trying to click on some option, it will crash.

13. Very similar to #8 (closed) in this list, selecting Mass Density and switching to the third option Mass will cause addie to crash with error Traceback (most recent call last): File "/SNS/users/3d0/miniconda3/envs/addie-env_test/lib/python3.6/site-packages/addie/processing/mantid/master_table/mass_density_handler.py", line 221, in mass_value_changed mass = np.float(self.ui.mass_line_edit.text()) ValueError: could not convert string to float: 'N/' Aborted (core dumped) Sometimes allows you to edit before crashing, Only way to edit is to highlight all of N/A and replace at once, trying to delete N/A one character at a time will cause crash. If number is in space, clearing the last character is what cause will crash, understandable since data type can no longer be a float.

14. Go to Rietveld tab and load in the attached GSAS data file (NOM161049tof.gsa), then go to Edit tab and click on Reset GSAS-tab will crash ADDIE, bringing up the following error message,

```
Traceback (most recent call last):
  File "/SNS/users/y8z/miniconda/envs/addie_env_3/lib/python3.6/site-packages/addie/main.py", line 773, in do_reset_gsas_tab
    bragg_event_handler.BraggTree.do_reset_gsas_tab(self)
  File "/SNS/users/y8z/miniconda/envs/addie_env_3/lib/python3.6/site-packages/addie/rietveld/braggtree.py", line 336, in do_reset_gsas_tab
    main_window._myController.delete_workspace(workspace)
  File "/SNS/users/y8z/miniconda/envs/addie_env_3/lib/python3.6/site-packages/addie/addiedriver.py", line 190, in delete_workspace
    raise RuntimeError('Workspace %s does not exist.' % workspace_name)
RuntimeError: Workspace Bank 1 - 15.099999999999994 does not exist.
Aborted (core dumped)
```

15. After resetting GSAS tab, trying to change units will result in addie crash, some of the children still remain on graph, probably need to make addition changes to fix #14 (closed)

```
File "/SNS/users/3d0/miniconda3/envs/addie-env_test/lib/python3.6/site-packages/addie/main.py", line 692, in evt_switch_bragg_unit
  rietveld_event_handler.switch_bragg_unit(main_window=self)
File "/SNS/users/3d0/miniconda3/envs/addie-env_test/lib/python3.6/site-packages/addie/rietveld/event_handler.py", line 377, in switch_bragg_unit
  assert len(ws_group_list) > 0, 'At least 1 GSS file must be selected.'
AssertionError: At least 1 GSS file must be selected.
Aborted (core dumped)
```

Trying to check some of the bank boxes will also cause a crash, need to find what fully resets window

In addition, changing the units while in something is actually graphed will automatically graph all banks

16. Load in several GSAS data (as attached here, NOM161121tof.gsa, NOM161122tof.gsa, NOM161123tof.gsa) in Rietveld tab and we will see those loaded in data under the Bragg Workspaces tree. Select all loaded-in data and right click on them to select Delete workspace. Following that, we then go ahead to change unit and ADDIE will crash, showing the following error,

```
Traceback (most recent call last):
  File "/SNS/users/y8z/miniconda/envs/addie_env_3/lib/python3.6/site-packages/addie/main.py", line 692, in evt_switch_bragg_unit
    rietveld_event_handler.switch_bragg_unit(main_window=self)
  File "/SNS/users/y8z/miniconda/envs/addie_env_3/lib/python3.6/site-packages/addie/rietveld/event_handler.py", line 377, in switch_bragg_unit
    assert len(ws_group_list) > 0, 'At least 1 GSS file must be selected.'
AssertionError: At least 1 GSS file must be selected.
Aborted (core dumped)
```

17. In Rietveld tab, after loading in some data (as attached here, NOM161121tof.gsa, NOM161122tof.gsa, NOM161123tof.gsa), if we select nothing in the Bragg Workspaces tree and click on the change unit dropdown menu, ADDIE will crash, throwing out the message,

```
Traceback (most recent call last):
  File "/SNS/users/y8z/miniconda/envs/addie_env_3/lib/python3.6/site-packages/addie/main.py", line 692, in evt_switch_bragg_unit
    rietveld_event_handler.switch_bragg_unit(main_window=self)
  File "/SNS/users/y8z/miniconda/envs/addie_env_3/lib/python3.6/site-packages/addie/rietveld/event_handler.py", line 377, in switch_bragg_unit
    assert len(ws_group_list) > 0, 'At least 1 GSS file must be selected.'
AssertionError: At least 1 GSS file must be selected.
```

18. In Rietveld tab, after loading in some data (as attached here, NOM161121tof.gsa, NOM161122tof.gsa, NOM161123tof.gsa), if we click on workspaces in the Bragg Workspaces tree and click on the change unit dropdown menu, ADDIE will crash, throwing out the message,

```
Traceback (most recent call last):
  File "/SNS/users/y8z/miniconda/envs/addie_env_3/lib/python3.6/site-packages/addie/main.py", line 692, in evt_switch_bragg_unit
    rietveld_event_handler.switch_bragg_unit(main_window=self)
  File "/SNS/users/y8z/miniconda/envs/addie_env_3/lib/python3.6/site-packages/addie/rietveld/event_handler.py", line 388, in switch_bragg_unit
    ws_group)
  File "/SNS/users/y8z/miniconda/envs/addie_env_3/lib/python3.6/site-packages/addie/addiedriver.py", line 296, in get_bank_numbers
    wksp = addie.utilities.workspaces.get_ws(ws_name)
  File "/SNS/users/y8z/miniconda/envs/addie_env_3/lib/python3.6/site-packages/addie/utilities/workspaces.py", line 33, in get_ws
    name), 'Workspace "{}" does not exist.'.format(name)
AssertionError: Workspace "workspaces" does not exist.
Aborted (core dumped)
```

19. Import some example data (as attached here, NOM161121tof.gsa, NOM161122tof.gsa, NOM161123tof.gsa) in Rietveld tab, we then right click on workspaces in Bragg Workspaces tree and all items there in the right click menu will crash ADDIE. This is because workspaces is just an indicator or place holder so any time when we right click on workspaces followed by clicking on any of the items in the right click menu, we just want to skip any operation (i.e. do nothing).

Priorities

Group-# Member Priority Subdivision Comments
1 1, 3, 4, 5, 6, 7, 8, 10, 12, 13, 14, 15 Critical 1 (#11 (closed)), 14 (#14 (closed)), 15 (#16 (closed)), 5 (#12 (closed)), 8 (#17 (closed)), 13 (#17 (closed)), 12 (#13 (closed)), 16 (#18 (closed)), 17 & 18 (#19 (closed)), 19 (#20 (closed)) \rightarrow 7 (#21 (closed)), 3 (#22 (closed)), 6 (#23 (closed)), 2 (#24 (closed)) \rightarrow 4 These are all the issues we need to fix before implementing the real functionality, i.e., preparing input for mantidtotalscattering and kick off the reduction
2 9, 10 High Two things need to happen when clicking on Launch Reduction, 1) prepare the input json file and 2) call mantidtotalscattering to run with the prepared json file
3 11 Low This will not be covered during the internship
Edited by Zhang, Yuanpeng