Commit 0cbd9015 authored by Håkan Wennlöf's avatar Håkan Wennlöf
Browse files

Merge branch 'b-toa' into 'v2.3-stable' 

[v2.3-stable] DefaultDigitizer: PixelHit::getGlobalTime always in ns

See merge request allpix-squared/allpix-squared!863
parents 23e8666a 217eb0e9

src/modules/DefaultDigitizer/DefaultDigitizerModule.cpp

+4 −4
Original line number Diff line number Diff line
@@ -284,11 +284,11 @@ void DefaultDigitizerModule::run(Event* event) { 
            h_px_toa->Fill(time);

        }



        // Simulate TDC if resolution set to more than 0bit

        if(tdc_resolution_ > 0) {

            // temporarily store full arrival time for histogramming:

        // Store full arrival time for global timestamp and histogramming:

        auto original_time = time;



        // Simulate TDC if resolution set to more than 0bit

        if(tdc_resolution_ > 0) {

            // Add TDC smearing:

            allpix::normal_distribution<double> tdc_smearing(0, tdc_smearing_);

            time += tdc_smearing(event->getRandomEngine());
@@ -311,7 +311,7 @@ void DefaultDigitizerModule::run(Event* event) { 
        }



        // Add the hit to the hitmap

        hits.emplace_back(pixel, time, pixel_charge.getGlobalTime() + time, charge, &pixel_charge);

        hits.emplace_back(pixel, time, pixel_charge.getGlobalTime() + original_time, charge, &pixel_charge);

    }



    // Output summary and update statistics

src/modules/DefaultDigitizer/README.md

+2 −1
Original line number Diff line number Diff line
@@ -18,7 +18,8 @@ In detail, the following steps are performed for every pixel charge: 
The QDC implementation also allows to simulate ToT (time-over-threshold) devices by setting the `qdc_offset` parameter to the negative `threshold`. Then, the QDC only converts charge above threshold.

* A time-to-digital converter (TDC) with configurable resolution, given in bit, can be simulated if pulse information is available from the input data. If the necessary pulse information is available from the input data, e.g. by using the PulseTransfer module to generate PixelCharge objects, this module calculates the time-of-arrival (ToA) as the time when the integrated input charge crosses the threshold. Also here, the absolute of the integrated charge is compared to a positive threshold value to be independent of the signal polarity.

First, the time from the start of the event until the first crossing of the charge threshold is calculated. It should be noted that this calculation does not take into account charge noise simulated in the QDC. The resulting ToA is smeared with a Gaussian distribution which allows to take TDC fluctuations into account. Then, the ToA is converted into TDC units using the `tdc_slope` and `tdc_offset` parameters provided. Finally, the calculated value is clamped to be contained within the TDC resolution, over- and underflows are treated as saturation.

If no time information is available from the input data, a time stamp of 0 is stored.

If no time information is available from the input data, a local time stamp of 0 is stored.

It should be noted that when using the TDC simulation, the local time stamp of the produced PixelHit object is provided in TDC bins rather than in nanoseconds of the framework-internal units. The global timestamp, however, is always provided in nanoseconds and independent of the TDC settings.



With the `output_plots` parameter activated, the module produces histograms of the charge distribution at the different stages of the simulation, i.e. before processing, with electronics noise, after threshold selection, and with ADC smearing applied.

A 2D-histogram of the actual pixel charge in electrons and the converted charge in QDC units is provided if QDC simulation is enabled by setting `qdc_resolution` to a value different from zero.