Commit 23e8666a authored by Håkan Wennlöf's avatar Håkan Wennlöf
Browse files

Merge branch 'b-coverity' into 'v2.3-stable' 

[v2.3-stable] Use reference instead of copy

See merge request allpix-squared/allpix-squared!858
parents 1c09523d a1797e60

src/core/module/Module.cpp

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ Module::Module(Configuration& config, std::shared_ptr<Detector> detector) 
Module::~Module() {

    // Remove delegates

    try {

        for(auto delegate : delegates_) {

        for(auto& delegate : delegates_) {

            delegate.first->remove_delegate(delegate.second);

        }

    } catch(std::out_of_range&) {

src/modules/GeometryBuilderGeant4/passive_models/GDMLModel.hpp

+1 −1
Original line number Diff line number Diff line
@@ -101,7 +101,7 @@ namespace allpix { 
                gdml_daughter->SetRotation(rotation_matrix);



                // Check if color information is available and set it to the daughter volume

                for(auto aux : parser_.GetVolumeAuxiliaryInformation(gdml_daughter_log)) {

                for(auto& aux : parser_.GetVolumeAuxiliaryInformation(gdml_daughter_log)) {

                    std::transform(aux.type.begin(), aux.type.end(), aux.type.begin(), ::tolower);

                    if(aux.type == "color" || aux.type == "colour") {

                        gdml_daughter_log->SetVisAttributes(G4VisAttributes(get_color(aux.value)));