Skip to content
Snippets Groups Projects
  1. Nov 26, 2020
  2. Nov 25, 2020
  3. Oct 26, 2020
  4. Sep 11, 2020
  5. Sep 10, 2020
  6. Jul 21, 2020
  7. Jul 15, 2020
  8. Jul 06, 2020
  9. Jun 13, 2020
    • Arseny Kapoulkine's avatar
      Work around a false positive in MSVC debug runtime checker · 23ca9404
      Arseny Kapoulkine authored
      In some MSVC versions on x64 configurations, the hashing function
      triggers this failure:
      
      Run-Time Check Failure #1 - A cast to a smaller data type has caused a
      loss of data.  If this was intentional, you should mask the source of
      the cast with the appropriate bitmask.
      
      This is similar to the integer sanitizer - this code is valid C++ but
      MSVC decides to warn about this nonetheless. Masking the pointer's low
      32 bits fixes the issue.
      
      Fixes #357.
      23ca9404
  10. May 11, 2020
  11. May 10, 2020
  12. May 02, 2020
    • Arseny Kapoulkine's avatar
      Clarify the document element behavior. · f49d7acd
      Arseny Kapoulkine authored
      pugixml currently unconditionally accepts documents with multiple
      top-level element nodes in absence of parse_fragment. This is an
      unfortunate omission; while it can be corrected, it will result in
      regressions for some users, and it's trivial to perform the validity
      check after the parse is done.
      
      Because of this, for now we're just going to amend documentation here to
      both highlight this in the W3C Conformance section, but also to more
      strongly push users into realizing that there's just a single document
      element (normally).
      
      We might decide to change the behavior here to prohibit such documents
      by default in the future, but for now a documentation change seems like
      a better tradeoff.
      
      Fixes #337
      f49d7acd
    • Arseny Kapoulkine's avatar
      Merge pull request #349 from KyleFromKitware/cmake-improvements · 28577635
      Arseny Kapoulkine authored
      Various CMake improvements
      28577635
  13. Apr 27, 2020
  14. Apr 25, 2020
  15. Feb 20, 2020
    • Arseny Kapoulkine's avatar
      Adjust node_copy_tree to be more explicit about invariants · 5e64076a
      Arseny Kapoulkine authored
      The loop traverses the source tree and simultaneously builds up a copy
      of it at destination. Short of race conditions, this code is safe -
      however, it's not obvious that dit stays inside the destination tree.
      
      This change adds a few assertions to help enforce/document these
      invariants. One particular subtlety is that dit can actually *become*
      null after we exit out of the loop, but it's guaranteed to only do so
      once sit goes back to sn.
      
      This is only possible when doing a full document copy - for some reason
      we weren't using this for that (in reset(xml_document)), but we are now.
      
      Fixes #314.
      5e64076a
  16. Feb 19, 2020
    • Arseny Kapoulkine's avatar
      XPath: Remove the use of fallthrough switch cases · 76c39144
      Arseny Kapoulkine authored
      We were previously relying on non-standard comment detection that is
      supported by gcc/clang to avoid warnings about implicit fallthrough.
      
      This can be solved using attributes but using them requires a lot of
      compiler-specific detection logic because not all versions of gcc/clang
      support them.
      
      We don't *really* need to rely on fallthrough here - the type conversion
      block can be located *after* the AST type switch instead, which means
      that any AST type that has type ambiguity can fall back to that in the
      future.
      
      Fixes #331.
      76c39144
  17. Feb 08, 2020
  18. Feb 07, 2020
  19. Feb 01, 2020
Loading