Commit 165677f8 authored by Wohlgemuth, Jason's avatar Wohlgemuth, Jason
Browse files

feat: Remove clippy rule disables

parent cffd5540

xylem-lib/Cargo.toml

+2 −0
Original line number Diff line number Diff line
@@ -42,6 +42,8 @@ uriparse = { workspace = true } 
assert_cmd = "2.1.1"



[lints.rust]

# missing-docs = "deny"

rust-2018-idioms = "warn"

unsafe_code = "forbid"



[lints.clippy]

xylem-lib/src/lib.rs

+2 −3
Original line number Diff line number Diff line 
#![allow(dead_code)]

#![allow(clippy::large_enum_variant)]

#![allow(clippy::wrong_self_convention)]

//! Xylem Library

//! > "Digital xylem" that transports data through workflows with structure and support

use acorn_lib::util::{read_file, Label};

use clap::ValueEnum;

use color_eyre::eyre::{Report, Result};

xylem-lib/src/script/mod.rs

+3 −3
Original line number Diff line number Diff line 
use acorn_lib::util::{read_file, to_absolute_string, Label, ToAbsoluteString};

use acorn_lib::{Location, Scheme};

use bon::{builder, Builder};

use core::convert::TryFrom;

use derive_more::{Display, FromStr};

use fancy_regex::Regex;

use owo_colors::OwoColorize;
@@ -8,7 +9,6 @@ use serde::ser::StdError; 
use serde::{Deserialize, Serialize};

use serde_json::{Map, Number, Value};

use std::collections::HashMap;

use core::convert::TryFrom;

use std::env::{set_var, vars};

use std::ffi::OsStr;

use std::io::{BufRead, BufReader};
@@ -131,7 +131,7 @@ pub enum ModuleUri<'a> { 
    /// }

    /// ```

    //TODO: Implement Serialize/Deserialize for URI - https://serde.rs/impl-serialize.html

    Url(URI<'a>),

    Url(Box<URI<'a>>),

    Unknown(String),

}

#[derive(Clone, Debug, Deserialize, Serialize)]
@@ -389,7 +389,7 @@ impl ModuleUri<'_> { 
    pub fn from(value: &str) -> ModuleUri<'_> {

        match URI::try_from(value) {

            | Ok(uri) => match uri.scheme() {

                | uriparse::Scheme::HTTP | uriparse::Scheme::HTTPS | uriparse::Scheme::SSH => ModuleUri::Url(uri),

                | uriparse::Scheme::HTTP | uriparse::Scheme::HTTPS | uriparse::Scheme::SSH => ModuleUri::Url(Box::new(uri)),

                | uriparse::Scheme::File => ModuleUri::File(PathBuf::from(uri.path().to_string())),

                | _ => ModuleUri::Unknown(value.to_string()),

            },