fixed a size_t / uint64_t problem for macOS 10.12 and Clang 8.1.0
Created by: JasonRuonanWang
Merge request reports
Activity
Created by: JasonRuonanWang
@chuckatkins I can change vector<size_t> to adios2::Dims if needed. But there has to be two sets of these variables, because some of the later code requires uint64_t, while some requires size_t. And this is ultimately because ADIOS 1 requires uint64_t and ADIOS 2 requires size_t. Thus it is unfixable without a substantial amount of work.
Created by: JasonRuonanWang
@chuckatkins I totally understand. But if I do so, then I am essentially moving the problem from heatRead_adios2 to heatRead_adios1. Because, firstly, heatRead_adios1 is based on ADIOS 1 API which requires uint64_t, and secondly, it uses the printData function, which is now changed to size_t. So whichever type I use, I have to keep two sets of these variables in either heatRead_adios1 or heatRead_adios2.
Created by: JasonRuonanWang
@williamfgc Yeah, I kind of know this. I am just trying to avoid making too many changes. Because this is not my code, if I make too much modification then it might break something else while fixing the problem I have now. Do you want me to cancel this pull request? I can use Linux temporarily until someone fixes it.
Created by: JasonRuonanWang
@williamfgc Then I need to move the printData function from .cpp to .h, or create another .tcc file. In the meantime, there is only one function in the .cpp file, so if I do so, I probable need to remove the .cpp file then. You see, there is a lot of things... which I am not sure any of you would mind.