Solve Issue #211 and made changes due to Windows warnings and bugs

Review changes
Download
Patches
Plain diff

Merged Solve Issue #211 and made changes due to Windows warnings and bugs

github/fork/williamfgc/windowsbugs into master

Overview 15
Commits 3
Pipelines 0
Changes 27

Merged Podhorszki, Norbert requested to merge github/fork/williamfgc/windowsbugs into master 7 years ago

Overview 15
Commits 3
Pipelines 0
Changes 27

Created by: williamfgc

Bugs: 1) Missing binary mode in FilePointer fopen and FStream ofstream transports was adding characters to bp files becoming corrupted. 2) Replacing reinterpret_cast of size_t to uint_64, not the same size on Windows 64-bit

Removed some warnings generated by Visual Studio

Added static_cast for type conversions

Refactor XML reader to restore original check on single engine conditions and eliminate warnings. Test added.

Allow ctime and fopen "not secure" warnings: now using binary fstream as default file IO library on Windows

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

Request review from

Labels

None

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

0 Participants

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.