Skip to content
Snippets Groups Projects

Updating some documentation, removed a warning and h5 file name

Merged Updating some documentation, removed a warning and h5 file name
github/fork/williamfgc/cleanup into release
Merged Podhorszki, Norbert requested to merge github/fork/williamfgc/cleanup into release

Created by: williamfgc

Warning triggered when -DCMAKE_BUILD_TYPE=Release on Mdtman

Merge request reports

Approval is optional

Merged by avatar (Mar 31, 2025 11:38pm UTC)

Merge details

  • Changes merged into release with 0849f848.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Podhorszki, Norbert
    Podhorszki, Norbert @pnb ·
    Author Owner

    Created by: chuckatkins

    Thanks for removing the warning change. In future PRs, rather than adding a commit to revert a change in a previous commit that's already part of the pr, it would be preferable to just re-write that previous commit. It's not something I'm going to nit-pick over now though, just something to keep in mind in the future.

    Looks good to me. Please merge.

Please register or sign in to reply