Skip to content

fix HDF5Reader build with MSVC

Podhorszki, Norbert requested to merge github/fork/germasch/pr/fix_hdf5_msvc into release

Created by: germasch

Sadly, variable-sized stack arrays are only a feature of C99, but not C++11, so this patch uses std::vector instead.

This fixes #1485 (closed), the second issue there, at least hopefully so -- @ax3l, could you test this one, too, as I don't think the adios2 CI covers this case. (I changed the place identified by the error message from your report, and one more place with the same issue, but there may be more).

@chuckatkins, I haven't checked, but my guess is that the MSVC CI doesn't build ADIOS2 with HDF5, otherwise I would have expected to see this problem earlier. So that may be something for the future todo list.

Merge request reports