Skip to content

adios2: consistent copy/move constructors and assignment

Podhorszki, Norbert requested to merge github/fork/germasch/move_ctor_assignment into master

Created by: germasch

This commit consistently disallows copy construction and assignment, but allows move construction and move assignment in adios2's cxx11 interface.

adios2's cxx11 interfaces deletes the copy constructor to guard against accidentally creating a copy of the ADIOS object. Unfortunately that also disallows the syntax

  auto ad = adios2::ADIOS(comm, ...);

which is otherwise equivalent to

  adios2::ADIOS ad(comm, ...);

While admittedly minor, it's a bit inconvenient for someone used to the former way. It's also inconsistent that the copy constructor is deleted, but copy assignment is allowed, so copies can be generated after all:

adios2::ADIOS ad;
adios2::ADIOS ad2 = ad;

will give an error, but

adios2::ADIOS ad;
adios2::ADIOS ad2;
ad2 = ad;

will succeed.

This PR consistently disallows copy construct and copy assignment, but it allows move construct and move assignment. So it actually prevents any copies of the ADIOS object, while allowing both ways of initializing an ADIOS type variable.

This PR may, however break existing application code that relies on copy assignment. It should be easy to fix by adding std::move.

Merge request reports