Merge pull request #305 from williamfgc/warnings

Resolving more cdash warnings issue #300

bindings/C/adios2/adios2_c_io.cpp

@@ -48,7 +48,7 @@ adios2_define_variable(adios2_IO *io, const char *name, const adios2_type type,
     switch (type)
     {
     case (adios2_type_string):
-        dynamic_cast<adios2::Variable<std::string> *>(
+        variable = dynamic_cast<adios2::Variable<std::string> *>(
             &ioCpp.DefineVariable<char>(name, shapeV, startV, countV,
                                         constantSizeBool));
         ;

bindings/fortran/modules/adios2_io_mod.f90

@@ -22,7 +22,7 @@ contains
         integer, intent(out) :: ierr
 
         call adios2_set_parameter_f2c( io, TRIM(ADJUSTL(key))//char(0), &
-            & TRIM(ADJUSTL(value))//char(0) )
+            & TRIM(ADJUSTL(value))//char(0), ierr )
 
     end subroutine
 

examples/heatTransfer/write/IO_adios2.cpp

@@ -21,7 +21,6 @@
 #endif
 #define DEFAULT_CONFIG_STR str(DEFAULT_CONFIG)
 
-static int rank_saved;
 adios2::ADIOS *ad = nullptr;
 adios2::Engine *bpWriter = nullptr;
 adios2::Variable<double> *varT = nullptr;
@@ -29,7 +28,6 @@ adios2::Variable<unsigned int> *varGndx = nullptr;
 
 IO::IO(const Settings &s, MPI_Comm comm)
 {
-    rank_saved = s.rank;
     m_outputfilename = s.outputfile + ".bp";
     ad = new adios2::ADIOS(std::string(DEFAULT_CONFIG_STR), comm,
                            adios2::DebugON);

testing/adios2/bindings/C/TestBPWriteTypes.cpp

@@ -26,8 +26,8 @@ public:
 
 TEST_F(BPWriteTypes, ADIOS2BPWriteTypes)
 {
-    int rank(0);
 #ifdef ADIOS2_HAVE_MPI
+    int rank(0);
     int size(0);
     adios2_ADIOS *adiosH = adios2_init(MPI_COMM_WORLD, adios2_debug_mode_on);
     MPI_Comm_rank(MPI_COMM_WORLD, &rank);

testing/adios2/interface/TestADIOSDefineVariable.cpp

@@ -19,11 +19,6 @@ protected:
 
 TEST_F(ADIOSDefineVariableTest, DefineGlobalValue)
 {
-    int mpiRank = 0, mpiSize = 1;
-#ifdef ADIOS2_HAVE_MPI
-    MPI_Comm_rank(MPI_COMM_WORLD, &mpiRank);
-    MPI_Comm_size(MPI_COMM_WORLD, &mpiSize);
-#endif
     std::string name = std::string("globalValue");
 
     // Define ADIOS global value