Minor changes to Reader and BeginStep

source/adios2/core/Engine.cpp

@@ -29,17 +29,18 @@ AdvanceStatus Engine::BeginStep()
 {
     if (m_OpenMode == Mode::Read)
     {
-        return BeginStep(AdvanceMode::NextAvailable, 0.0);
+        return BeginStep(AdvanceMode::NextAvailable, 0.0f);
     }
     else
     {
-        return BeginStep(AdvanceMode::Append, 0.0);
+        return BeginStep(AdvanceMode::Append, 0.0f);
     }
 }
 
-AdvanceStatus Engine::BeginStep(AdvanceMode mode, const float timeout_sec)
+AdvanceStatus Engine::BeginStep(AdvanceMode mode, const float timeoutSeconds)
 {
     ThrowUp("BeginStep");
+    return AdvanceStatus::OtherError;
 }
 void Engine::EndStep() { ThrowUp("EndStep"); }
 

source/adios2/core/Engine.h

@@ -62,9 +62,9 @@ public:
      */
     IO &GetIO() noexcept;
 
-    virtual AdvanceStatus BeginStep() final;
+    AdvanceStatus BeginStep() final;
     virtual AdvanceStatus BeginStep(AdvanceMode mode,
-                                    const float timeout_sec = 0.0);
+                                    const float timeoutSeconds = 0.f);
 
     /**
      * Puts variable with pre-defined pointer at DefineVariable into adios2

source/adios2/engine/bp/BPFileReader.tcc

@@ -22,6 +22,8 @@ void BPFileReader::GetSyncCommon(Variable<T> &variable, T *data)
     // subfile info
     const std::map<std::string, SubFileInfoMap> variableSubfileInfo =
         m_BP3Deserializer.GetSyncVariableSubFileInfo(variable);
+
+    ReadVariables(m_IO, variableSubfileInfo);
 }
 
 template <class T>