Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
ADIOS2
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Podhorszki, Norbert
ADIOS2
Commits
15de86ed
Commit
15de86ed
authored
7 years ago
by
Atkins, Charles Vernon
Browse files
Options
Downloads
Patches
Plain Diff
Reinstate the use of reinterpret_cast
parent
a4ad2d7a
No related branches found
No related tags found
1 merge request
!28
Reinstate the use of reinterpret_cast
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
.clang-tidy
+1
-1
1 addition, 1 deletion
.clang-tidy
source/format/BP1Writer.cpp
+9
-9
9 additions, 9 deletions
source/format/BP1Writer.cpp
with
10 additions
and
10 deletions
.clang-tidy
+
1
−
1
View file @
15de86ed
Checks: -*,cppcoreguidelines-*,google-*,llvm-*,misc-*,modernize-*,performance-*,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-google-runtime-int
Checks: -*,cppcoreguidelines-*,google-*,llvm-*,misc-*,modernize-*,performance-*,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-
cppcoreguidelines-pro-type-reinterpret-cast,-
google-runtime-int
CheckOptions:
- key: google-runtime-int.TypeSuffix
...
...
This diff is collapsed.
Click to expand it.
source/format/BP1Writer.cpp
+
9
−
9
View file @
15de86ed
...
...
@@ -72,7 +72,7 @@ void BP1Writer::WriteProcessGroupIndex(
// offset to pg in data in metadata which is the current absolute position
CopyToBuffer
(
metadataBuffer
,
static
_cast
<
uint64_t
*>
(
&
heap
.
m_DataAbsolutePosition
));
reinterpret
_cast
<
uint64_t
*>
(
&
heap
.
m_DataAbsolutePosition
));
// Back to writing metadata pg index length (length of group)
const
std
::
uint16_t
metadataPGIndexLength
=
...
...
@@ -206,7 +206,7 @@ void BP1Writer::WriteDimensionsRecord(
auto
lf_WriteFlaggedDim
=
[](
std
::
vector
<
char
>
&
buffer
,
const
char
no
,
const
std
::
size_t
dimension
)
{
CopyToBuffer
(
buffer
,
&
no
);
CopyToBuffer
(
buffer
,
static
_cast
<
const
uint64_t
*>
(
&
dimension
));
CopyToBuffer
(
buffer
,
reinterpret
_cast
<
const
uint64_t
*>
(
&
dimension
));
};
// BODY Starts here
...
...
@@ -227,8 +227,8 @@ void BP1Writer::WriteDimensionsRecord(
{
for
(
const
auto
&
localDimension
:
localDimensions
)
{
CopyToBuffer
(
buffer
,
static_cast
<
const
uint64_t
*>
(
&
localDimension
));
CopyToBuffer
(
buffer
,
reinterpret_cast
<
const
uint64_t
*>
(
&
localDimension
));
buffer
.
insert
(
buffer
.
end
(),
skip
,
0
);
}
}
...
...
@@ -250,12 +250,12 @@ void BP1Writer::WriteDimensionsRecord(
{
for
(
unsigned
int
d
=
0
;
d
<
localDimensions
.
size
();
++
d
)
{
CopyToBuffer
(
buffer
,
static_cast
<
const
uint64_t
*>
(
&
localDimensions
[
d
]));
CopyToBuffer
(
buffer
,
static
_cast
<
const
uint64_t
*>
(
CopyToBuffer
(
buffer
,
reinterpret_cast
<
const
uint64_t
*>
(
&
localDimensions
[
d
]));
CopyToBuffer
(
buffer
,
reinterpret
_cast
<
const
uint64_t
*>
(
&
globalDimensions
[
d
]));
CopyToBuffer
(
buffer
,
static_cast
<
const
uint64_t
*>
(
&
globalOffsets
[
d
]));
CopyToBuffer
(
buffer
,
reinterpret_cast
<
const
uint64_t
*>
(
&
globalOffsets
[
d
]));
}
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment