Skip to content

OpenMC integration fixes/minor updates

Kiesling, Kalin Rose requested to merge openmc-minor into development

Prerequisites Checklist

Self-review checklist:

  • My code follows the style guidelines and software coding standards for this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added appropriate tests that prove my fix/feature is effective.
  • If the source branch will not be used after this MR, I have set it to be deleted upon merging.

Documentation checklist:

  • I have checked the README and updated it if necessary.
  • I have checked the tutorial and made any documenation or results updates if necessary.
  • I have updated the CHANGELOG.

Does this MR relate to a specific issue? If so, link the issue.

Addresses parts of #88

Description of Changes

Addressing some of the minor changes to the OpenMC integration to make it more user friendly:

  1. Output tables (tallies and volume) are delimited with | now instead of just spaces
  2. Schema has been fixed to address some buggy tab completing - let me know if the schema is still not quite right
  3. Breaking change: mcsim/codes has been removed as an input option and the Shift placeholder class was deleted as it is not going to be integrated at this point. All mcsim runs will be with OpenMC only. Eventually (not this MR), the MCSim class will be renamed to be OpenMC only but that is a more substantial breaking change that I prefer to implement closer to our planned major release at the end of the FY.
  4. Tutorial was updated for these formatting and schema changes.

I am looking into how to capture the OpenMC terminal output to put it in the log file (one of the requests in the issue linked), but the capturing of that output is not very straightforward. If I can figure it out, I will add it to this MR, but right now I don't think it will be easily implementable.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected or break backwards compatibility)

Additional Information

Edited by Kiesling, Kalin Rose

Merge request reports