Fallback on poster if pycurl is unavailable.

Poster is not the best candidate because it is kind of old and likely uncompatible with Python 3 - but is available in Galaxy. Should be targetting requests + requests_toolbelt I guess.

pulsar/client/transport/__init__.py

@@ -25,7 +25,12 @@ def __get_transport_type(transport_type, os_module):
 
 # TODO: Provide urllib implementation if these unavailable,
 # also explore a requests+poster option.
-from .curl import get_file
-from .curl import post_file
+from .curl import curl_available
+if curl_available:
+    from .curl import get_file
+    from .curl import post_file
+else:
+    from .poster import get_file
+    from .poster import post_file
 
 __all__ = [get_transport, get_file, post_file]

pulsar/client/transport/curl.py

@@ -2,10 +2,11 @@ try:
     from cStringIO import StringIO
 except ImportError:
     from io import StringIO
+curl_available = True
 try:
     from pycurl import Curl
 except ImportError:
-    pass
+    curl_available = False
 from os.path import getsize
 
 

pulsar/client/transport/poster.py

+from __future__ import absolute_import
+try:
+    from urllib2 import urlopen
+except ImportError:
+    from urllib.request import urlopen
+try:
+    from urllib2 import Request
+except ImportError:
+    from urllib.request import Request
+try:
+    from galaxy import eggs
+    eggs.require("poster")
+except ImportError:
+    pass
+
+try:
+    import poster
+except ImportError:
+    poster = None
+
+POSTER_UNAVAILABLE_MESSAGE = ""
+
+import logging
+log = logging.getLogger(__name__)
+
+
+if poster is not None:
+    poster.streaminghttp.register_openers()
+
+
+def post_file(url, path):
+    __ensure_poster()
+    try:
+        datagen, headers = poster.encode.multipart_encode({"file": open(path, "rb")})
+        request = Request(url, datagen, headers)
+        return urlopen(request).read()
+    except:
+        log.exception("problem")
+        raise
+
+
+def get_file(url, path):
+    __ensure_poster()
+    request = Request(url=url)
+    response = urlopen(request)
+    with open(path, 'wb') as output:
+        while True:
+            buffer = response.read(1024)
+            if not buffer:
+                break
+            output.write(buffer)
+
+
+def __ensure_poster():
+    if poster is None:
+        raise ImportError(POSTER_UNAVAILABLE_MESSAGE)

test/integration_test.py

@@ -2,7 +2,12 @@ from os.path import join
 from os import makedirs, system
 from six import next, itervalues
 from six.moves import configparser
-from .test_utils import TempDirectoryTestCase, skipUnlessExecutable, skipUnlessModule
+from .test_utils import (
+    TempDirectoryTestCase,
+    skipUnlessExecutable,
+    skipUnlessModule,
+    skipUnlessAnyModule
+)
 
 from .test_utils import test_pulsar_app
 from .test_utils import test_pulsar_server
@@ -153,7 +158,7 @@ class IntegrationTests(BaseIntegrationTest):
 class DirectIntegrationTests(IntegrationTests):
     default_kwargs = dict(direct_interface=True, test_requirement=False)
 
-    @skipUnlessModule("pycurl")
+    @skipUnlessAnyModule(["pycurl", "poster"])
     def test_integration_remote_transfer(self):
         self._run(
             private_token=None,

test/test_utils.py

@@ -187,6 +187,19 @@ def skipUnlessModule(module):
     return skip("Module %s could not be loaded, dependent test skipped." % module)
 
 
+def skipUnlessAnyModule(modules):
+    available = False
+    for module in modules:
+        try:
+            __import__(module)
+        except ImportError:
+            continue
+        available = True
+    if available:
+        return lambda func: func
+    return skip("None of the modules %s could be loaded, dependent test skipped." % modules)
+
+
 def __which(program):
 
     def is_exe(fpath):