This project is mirrored from https://github.com/mantidproject/mantid.git. Pull mirroring updated .
  1. 23 Mar, 2020 1 commit
  2. 20 Mar, 2020 5 commits
  3. 19 Mar, 2020 9 commits
  4. 18 Mar, 2020 4 commits
  5. 17 Mar, 2020 5 commits
  6. 16 Mar, 2020 7 commits
  7. 13 Mar, 2020 9 commits
    • Whitfield, Ross's avatar
      Merge pull request #28350 from mantidproject/findY_NaN · 27c84940
      Whitfield, Ross authored
      Change behavior of MatrixWorkspace::findY when value=NaN
      27c84940
    • Martyn Gigg's avatar
      Wrap mantiddoc Sphinx logger usage for version 1.2 · bd203f44
      Martyn Gigg authored
      The sphinx.util.logging framework was not available
      in version 1.2 that is currently used by RHEL 7. This wraps
      the calls and chooses an appropriate implementation.
      bd203f44
    • Nick Draper's avatar
      Merge pull request #28370 from DanNixon/only_find_opengl_if_needed · 64b29024
      Nick Draper authored
      Only find OpenGL if it is enabled
      64b29024
    • David Fairbrother's avatar
      Re #26703 Replace deprecated API with tbb:global_control · fa503553
      David Fairbrother authored
      Replaces the deprecated scheduler_init with global_control. This should
      future proof us, and completely avoids all the threading issues we were
      seeing previously.
      
      The TBB_PREVIEW_GLOBAL_CONTROL macro is required until TBB 2019U4, or 11
      internally. So for simplicity we will make platforms using an older
      version of TBB (RHEL7 and Ubuntu at writing) switch to scheduler init
      fa503553
    • Harriet Brown's avatar
      Replace final header guards missed by auto replace with pragma once · 713daedc
      Harriet Brown authored
      This commit removes the final header guard that had
      been missed by the auto replacer.
      
      re: #28200
      713daedc
    • David Fairbrother's avatar
      Re #26703 Fix TBB Threading issue · 42793d09
      David Fairbrother authored
      Fixes the following assertion thrown by TBB:
      
      	Attempt to terminate non-local scheduler instance
      
      This took a significant amount of time to track down due to a number of
      factors. If your looking for a quick fix; set your
      tbb::task_scheduler_init to use thread local storage.
      
      This is caused by using Python multi-processing (in our case for the
      system tests). The process will spawn correctly (Windows), however
      Python will helpfully create seperate thread(s). I assume to observe. In
      this case the task_scheduler_init handle would then belong to one of
      these threads, as the act of importing our Python module would init the
      framework and TBB implicitly.
      
      When the tests run and TBBs scheduling is required it will "sign_on" in
      tbb's governor.cpp to handle scheduling. This works because the
      scheduler_init handle
      is process wide. However internally they then use thread local storage
      (TLS) for tracking the scheduler.
      
      As the main process goes to destruct it assumes that we must have
      a scheduler instance, since at process level we have done the init.
      
      But we cannot see any schedulers since they belong to a different
      thread. We have been getting away with this as the TLS returns NULL
      which effectively nops the destruction. But the assert correctly points
      out were getting this wrong.
      
      Marking each handle to the scheduler as thread local effectively ties
      the destruction of the thread to its init status. For most threads this
      effectively means we create a unique_ptr which isn't used. But for our
      main threads and weird edge case worker threads it keeps the thread
      state consistent.
      
      We've used a unique_ptr since we have an API which allows us to change
      the number of threads TBB can spin up. However, anyone else facing this
      issue would probably be fine with a thread local object allocated on the
      stack.
      42793d09
    • Nick Draper's avatar
      Merge pull request #28265 from mantidproject/28093_only_retain_running_algorithms · 83d2ed91
      Nick Draper authored
      Remove the dodgy passing of algorithms in *Dialog methods
      83d2ed91
    • David Fairbrother's avatar
      Updates TBB to 2020U1 . · aab615f0
      David Fairbrother authored
      aab615f0
    • Hahn, Steven's avatar
      cpp-check · 9cb86f78
      Hahn, Steven authored
      
      
      Signed-off-by: Hahn, Steven's avatarSteven Hahn <hahnse@ornl.gov>
      9cb86f78