LoadNexusLogs now extends NexusHDF5Descriptor
Allow HDF5 open to handle multiple handlers in NexusHDF5Descriptor

Expose m_fileInfo from NexusFileLoader

To do:
LoadNexusMonitors2

This means we can hide the parsing function that takes an xml string from the public interface and add a friend class to test this.
It also means that getRuns() can be called multiple times with different criteria without having to re-parse the file.

Re #26897

Giovanni Di Siena authored 5 years ago and Gigg, Martyn Anthony committed 4 years ago

In places other substitutions have been made, e.g
Clang does not yet specialize std::shared_ptr for T[]. Vector
has been used instead. The operator[] methods were incorrectly
marked const but returning a non-const reference - this has been fixed.
Refs #25842

Adds a couple of generic functions for requesting data from a journal. The main work is done by a function that takes the file contents as a string so that this can be easily tested. A wrapper function allows the file to first be fetched from a URL constructed for the instrument and cycle.

Also adds a couple of functions for requesting the list of cycles, again with one function taking the file contents and another which finds the URL for the instrument.

Re #26897

Miscellaneous code review comments to add comments, remove redundant brackets
Also added comment to the sample environment concept page to explain where
Mantid will search for the attenuation profile file

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Runs clang-tidy pass by ref across the codebase to fix-up various
warnings we are seeing in cppcheck

Hand-fixes some cppcheck warnings, this was work prior to fixing the
cppcheck target.

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Also rewrite SaveNXTomo to stop reusing the same algroithm

Not convinced this kind of test is useful. Better to test the functionality
rather than things like parameter\property counts