Refs #22286

This is in an effort to sort out platform dependencies
Refs #22286

Prevent crash - missing error handling in `RunCombinationHelper`

Indirect - QENS Fitting - QENSFitSequential algorithm

Refs #22383

Refs #22383

OSX
FAILED: Framework/SINQ/test/CMakeFiles/PSISINQTest.dir/PoldiIndexKnownCompoundsTest.cpp.o
In file included from Framework/SINQ/test/PoldiIndexKnownCompoundsTest.cpp:17:
PoldiIndexKnownCompoundsTest.h:40:5: error: no matching function for call to 'storeWS'
    WorkspaceCreationHelper::storeWS(
WorkspaceCreationHelper.h:114:33: note: candidate function [with WSType = boost::shared_ptr<Mantid::DataObjects::TableWorkspace>] not viable: expects an l-value for 2nd argument
template <typename WSType> void storeWS(const std::string &name, WSType &ws) {
In file included from Framework/SINQ/test/PoldiIndexKnownCompoundsTest.cpp:17:
PoldiIndexKnownCompoundsTest.h:43:5: error: no matching function for call to 'storeWS'
    WorkspaceCreationHelper::storeWS(
WorkspaceCreationHelper.h:114:33: note: candidate function [with WSType = boost::shared_ptr<Mantid::DataObjects::TableWorkspace>] not viable: expects an l-value for 2nd argument
template <typename WSType> void storeWS(const std::string &name, WSType &ws) {
In file included from Framework/SINQ/test/PoldiIndexKnownCompoundsTest.cpp:17:
PoldiIndexKnownCompoundsTest.h:673:7: error: no matching function for call to 'storeWS'
      WorkspaceCreationHelper::storeWS(
WorkspaceCreationHelper.h:114:33: note: candidate function [with WSType = boost::shared_ptr<Mantid::DataObjects::Workspace2D>] not viable: expects an l-value for 2nd argument
template <typename WSType> void storeWS(const std::string &name, WSType &ws) {
3 errors generated.

Linux
PoldiIndexKnownCompoundsTest.h:42:66: error: invalid initialization of non-const reference of type ‘boost::shared_ptr<Mantid::DataObjects::TableWorkspace>&’ from an rvalue of type ‘Mantid::DataObjects::TableWorkspace_sptr {aka boost::shared_ptr<Mantid::DataObjects::TableWorkspace>}’
          PoldiPeakCollectionHelpers::createPoldiPeakTableWorkspace());
PoldiIndexKnownCompoundsTest.cpp:17:
WorkspaceCreationHelper.h:114:33: note:   initializing argument 2 of ‘void WorkspaceCreationHelper::storeWS(const string&, WSType&) [with WSType = boost::shared_ptr<Mantid::DataObjects::TableWorkspace>; std::__cxx11::string = std::__cxx11::basic_string<char>]’
10:35:30  template <typename WSType> void storeWS(const std::string &name, WSType &ws) {
PoldiIndexKnownCompoundsTest.cpp:17:0:
PoldiIndexKnownCompoundsTest.h:46:31: error: invalid initialization of non-const reference of type ‘boost::shared_ptr<Mantid::DataObjects::TableWorkspace>&’ from an rvalue of type ‘Mantid::DataObjects::TableWorkspace_sptr {aka boost::shared_ptr<Mantid::DataObjects::TableWorkspace>}’
              ->asTableWorkspace());
WorkspaceCreationHelper.h:114:33: note:   initializing argument 2 of ‘void WorkspaceCreationHelper::storeWS(const string&, WSType&) [with WSType = boost::shared_ptr<Mantid::DataObjects::TableWorkspace>; std::__cxx11::string = std::__cxx11::basic_string<char>]’
  template <typename WSType> void storeWS(const std::string &name, WSType &ws) {
PoldiIndexKnownCompoundsTest.cpp:17:0:
PoldiIndexKnownCompoundsTest.h: In member function ‘void PoldiIndexKnownCompoundsTest::storeRandomWorkspaces(const std::vector<std::__cxx11::basic_string<char> >&)’:
PoldiIndexKnownCompoundsTest.h:674:65: error

Refs #22383

Refs #22383

- Doxygen updated (throws)
- Templated storeWS

Running ConjoinXRunsTest for testTableInputWorkspaceInGroupThrows:
ConjoinXRuns-[Warning] Invalid value for InputWorkspaces: Workspace table is not a MatrixWorkspace

showing the need to check !ws and + input + works (ll 128,130 in ConjoinXRuns.cpp)

Refs #22383

Remove the EPPWorkspace input property from DirectILLCollectData

Refactor MuonMaxEnt in Frequency Domain Analysis

Allow LoadWAND to load multiple file

Fix ConvertToMD with workspace pointer input

Refs #22286

This should help track down error in windows build.
Refs #22286

Update inputsplitter.py

Refs #22286

Refs #22286

The values were different in the fourth place past the decimal.
Refs #22286

Refs #22286

And group the loaded files. Also add option to load by setting IPTS and run numbers.

Some options were in place as maybe they'll be eventually needed.
This removes those and continues the cleanup. Refs #22286

Fix pessimizing-move warnings from Apple Clang 9

ISIS Powder prevent infinite recursion when deep-copying instrument settings object

RunCombinationHelper checks, if the ws is a GroupWorkspace or else a MatrixWorkspace. Workspaces of the group were not checked and need to be checked during validation

Refs #22383

Without catching the error, MantidPlot freezes forever for this case

Refs #22383

- Checked if MatrixWorkspace now done in unWrapGroups
- Cannot get the name if pointer is invalid in ConjoinXRuns
- Added unit test in RunCombinationHelperTest

Refs #22383

Refs #22275

Refs #22275

Refs #22275