This project is mirrored from https://github.com/mantidproject/mantid.git.
Pull mirroring updated .
- Feb 02, 2020
-
-
Danny Hindson authored
Also required updates to system test files. Updates to complexShapeAbsorptionsTest include changes to increase number of scenarios and increase of tolerance so tests are more robust to changes in random number sequences in MC simulation
-
- Jan 29, 2020
-
-
Danny Hindson authored
-
Danny Hindson authored
I have deleted the MultiPartEnvironmentOverlap test because it wasn't being run due to the parent class being SampleShapeBase instead of SampleEnvironment. The test MultiPartEnvironmentTranslate already tests overlapping environment components with a +/- 2.5 offset on two components based on cube.stl (cube.stl is a 10 x 10 x 30 cuboid) so didn't seem benefit in fixing the xxxOverlap test
-
- Jan 28, 2020
-
-
Danny Hindson authored
A switch has been added to the MCAbsorptionStrategy class that allows a pair of before scatter\after scatter tracks to be used to calculate the attenuation for a range of different lambda values. This will improve the speed of the Monte Carlo calculation. The Monte Carlo calculation currently sets the switch to reuse the tracks without exposing this in the algorithm parameters - I've mainly left the "old" approach in place in case any further wavelength dependent effects are added to the absorption calculation eg beam spreading In order to add the reuse while retaining the original behaviour (via the switch), I had to reverse the order of the event and lambda loops. The previous code looped over lambda with an inner loop of events. The event loop is now the outer loop, so even with the switch set to not reuse tracks the results will change slightly if the simulation isn't converged The function MCInteractionVolume::calculateAbsorption has been split into two: - track generated done in calculateBeforeAfterTrack - absorption calculation done in calculateAbsorption The relevant unit and system tests have been adjusted. In particular the tests in MCInteractionVolumeTest have been split out so the track generation and absorption calculation are tested separately
-
- Jan 21, 2020
-
-
David Fairbrother authored
Switches to using the JSON library for parsing SANS state objects. This provides numerous advantages: - We do not need to maintain a custom (de)serializer - JSON is a documented standard - We can switch to type hinting in Python 3, currently a significant amount of CPU time is spend reverifying typed params - History becomes less brittle and will work from top level algorithms - Allows new code to be written in a more Pythonic way (e.g. not forced to use class level variables for them to be serialized)
-
- Jan 20, 2020
-
-
Danny Hindson authored
The sampling is now performed according to the volume of each part of the sample\environment that intersects the beam profile Following changes have been made: a) the function IObject::generatePointInObject has been modified so that it returns false rather than raising an exception if it fails to generate a point inside the object that is also in the active region. This is more efficient when it is being called with a maxAttempts value of 1 in an attempt to fairly sample the scatter points among the sample + environment components. This involved a change in IObject and various child classes (MeshObject, CSGObject, MeshObject2D, Container) b) the code that calls IObject::generatePointInObject and cycles through the various parts of the environment\sample has been moved from SampleEnvironment into MCInteractionVolume so that the sample can be included. There is a new function MCInteractionVolume::generatePoint that randomly generates a scatter point across the sample and environment components. Possible the SampleEnvironment class could be retired entirely and just replaced by a vector of IObject items attached to the sample. c) change CSGObject::generatePointInObject to stop calling the fallback method when the maxAttempts parameter equals 1. The fallback method always returns a point if the object's bounding box is inside the active area which doesn't produce the required sampling across the env components. This change has modified the random number sequences used in various tests - including the "sample only" tests d) added some logging to the simulation to show where the scatter points occurred. These show that for Pearl around 6% of the scatter points are in the sample which is less than the 50% assumption previously in the code e) Several changes to the unit tests (MCInteractionVolumeTest.h, MonteCarloAbsorptionTest.h, DirectILLSelfShieldingTest.py). The updated sampling means that the absorption corrections are slightly different than before for cases with a sample + environment. For DirectILLSelfShieldingTest, an extra parameter has been added to underlying algorithm (DirectILLSelfShielding) so that this test can continue to use 300 events per point while the ILLDirectGeometryReductionTest can use 5000 events per point f) some changes to system tests (ILLDirectGeometryReductionTest, complexShapeAbsorptions) The calculation used in ILLDirectGeometryReductionTest wasn't converged (changing the seed gave a ~25% change in the output) so have increased the number of events per point from 300 to 5000. I didn't increase the number of events further because I didn't want to make the runtime of the system test (esp in debug mode) too large
-
- Jan 17, 2020
-
-
Harriet Brown authored
re #27554
-
Gagik Vardanyan authored
-
- Jan 09, 2020
-
-
Gigg, Martyn Anthony authored
minixsv is not Python 3 compatible. Consolidates all XML validation to single module to reduce code duplication. Refs #16578
-
- Jan 06, 2020
-
-
Harriet Brown authored
This commit add the option for the user to set the PDF output type on the polaris create_total_scattering_pdf function. They can use any of the types available through PDFFourierTransform (G(r), g(r), RDF(r)), if none given it will default to G(r). Re #27607
-
- Jan 03, 2020
-
-
Gemma Guest authored
This file was added by mistake. Re #25881
-
- Dec 19, 2019
-
-
Gemma Guest authored
The new reference file has the following changes: - The IvsQ_binned results contain slightly different values due to binning differences to the original tests which did a manual Rebin of the detectors and monitors workspaces. The new workflow algorithm just rebins the detectors the same as the monitors. If I hack the script to use the old rebin params I get exactly the same results, so this confirms that functionally the new script is correct. - The new reference includes some interim workspaces (e.g. IvsQ and TOF) which were deleted in the original test scripts. These are standard outputs so I think it's better to include them. - The test script has been updated to not delete the interim workspaces mentioned above. It also now does delete the interim TRANS_LAM workspaces, because the workflow algorithms currently always output these for input workspace groups, even though they shouldn't really if debug is not on. Re #25881
-
Gemma Guest authored
There are differences between the old FilterByTime algorithm and the new FilterEvents algorithm. This commit adds an option so the user can specify which to use and sets the default to use the old one. Also, when combining the monitors and detectors into a single workspace, we were merging the logs, which meant the proton charge is different to previous behaviour when scientists were doing this step manually. This commit changes MergeLogs to be false in line with the way scientists previously did this. I'm not sure this is really an issue because the final proton charge for the workspace is taken from the monitor workspace, which contains the unfiltered proton charge. We may want to adjust this in future to be the proton charge for the filtered slice. Re #25881
-
Gemma Guest authored
Remove duplicate code in the original tests and make them use the new base class instead. Also fix some problems with the regenerate functions to ensure they use the correct test suite. Update the slicing test result workspace with the correct workspace names (the actual workspaces themselves are the same, just the names have changed). Re #25881
-
Gemma Guest authored
- The 'Preprocess' test does 'normal' preprocessing, which involves loading runs and preparing the transmission workspace. - The 'Slicing' test performs time slicing of the input event workspace before performing the reduction. Re #25881
-
Gemma Guest authored
Direct use of ReflectometryReductionOneAuto has been superseded by the new wrapper algorithm ReflectometryISISLoadAndProcess. The system tests have been updated to use this wrapper instead. Re #25881
-
- Dec 13, 2019
-
-
WHITFIELDRE email authored
-
- Dec 11, 2019
-
-
Jose Borreguero authored
Signed-off-by:
Jose Borreguero <borreguero@gmail.com>
-
- Dec 09, 2019
-
-
Harriet Brown authored
This commit changes the value of the output of TotalScatteringMergedTest. The output value was changed by commit 6ca379 that changed how the pdf was calculated. Re #27445
-
- Dec 06, 2019
-
-
David Fairbrother authored
Add SANS to LOQ system test names so that -R SANS works correctly
-
- Dec 03, 2019
-
-
WHITFIELDRE email authored
-
- Nov 27, 2019
-
-
David Fairbrother authored
-
- Nov 26, 2019
-
-
David Fairbrother authored
-
David Fairbrother authored
-
David Fairbrother authored
-
David Fairbrother authored
-
David Fairbrother authored
-
- Nov 22, 2019
-
-
Danny Hindson authored
-
Danny Hindson authored
Some validate calls were failing due to ws cleanup happening too early Rename tearDown to cleanup in some system tests because cleanup is already called from the runner + remove explicit calls to tearDown inserted in previous commit
-
- Nov 21, 2019
-
-
Danny Hindson authored
-
- Nov 18, 2019
-
-
David Fairbrother authored
-
- Nov 14, 2019
-
-
Martyn Gigg authored
-
- Nov 12, 2019
-
-
David Fairbrother authored
Changes the expected names for system tests to take account of the appended suffix for custom names, or adds an underscore between the run number and details
-
- Nov 11, 2019
-
-
Martyn Gigg authored
Allows for more control rather than hard coding the range. Changes the default to integrate over the whole range as requested by A Gibbs. Adds a system test including the solid angle corrections Refs #27238
-
- Nov 08, 2019
-
-
Jose Borreguero authored
Signed-off-by:
Jose Borreguero <borreguero@gmail.com>
-
David Fairbrother authored
-
Gigg, Martyn Anthony authored
Recent updates to the IDF and test results now require a slightly higher tolerance but it is still within acceptable limits.
-
- Nov 07, 2019
-
-
Jose Borreguero authored
Signed-off-by:
Jose Borreguero <borreguero@gmail.com>
-
- Nov 06, 2019
-
-
Martyn Gigg authored
The flight paths have been updated slightly so the d-spacing related results have changed slightly. Confirmed that this is acceptable for old results with C Ridley.
-
- Oct 30, 2019
-
-
Gigg, Martyn Anthony authored
Covers differences in Spline on Windows/Linux
-