Giovanni Di Siena authored 4 years ago and Gigg, Martyn Anthony committed 4 years ago

In places other substitutions have been made, e.g
Clang does not yet specialize std::shared_ptr for T[]. Vector
has been used instead. The operator[] methods were incorrectly
marked const but returning a non-const reference - this has been fixed.
Refs #25842

It is a header that is heavy and should never be needed in another header.
It's long include chain now also has issues with older moc versions not
parsing nested namespaces

Removes all of the from __future__ imports that open and close the
brackets on the same line. This is most of them.

Runs clang-tidy pass by ref across the codebase to fix-up various
warnings we are seeing in cppcheck

Also updated class_maker.py

This commit replaces all header guards in MantidPlot with #pragma once.

re #28093

Remove plotSpectrum and plotBin for MantidPlot scripts to remove the conflict with old plotting functions

Refs #27744

Ensures our 3rdparty Python is picked up first so that
any warnings are suppressed by the /external warning
suppression on MSVC

The version of python36-sip in EPEL produces a PyQt4 that segfaults
when an eventFilter is overridden in Python. So as to not introduce
any further custom rpms we build and package a private copy of PyQt4
for Python 3 builds on EL7
Refs #27631

It is required for Tornado as used within the embedded jupyter console. See
code comments for documentation link.
Refs #16578

Refs #16578

Disables GCC functional cast warnings where we have a C++ Python
interface, as the Python pattern is to get generic PyObject pointers and
up-cast them to the relevant type.

We use generator expressions to determine if we are GCC 8 onwards and
append the Wno-cast-function-type flag to targets with a valid reson to
have these casts

Unfortunately because MantidPlot pulls in one sip file we can't add it
there, however as it's fallen out of development this shouldn't affect
us long term

I've modified getDockedOrFloatingWindow so it's more general and
works when the IndirectSettings window is an independent window
and also has a parent. I'm not convinced the #if #endif that checks
the Qt version (essentially whether we're in Workbench or MantidPlot)
is absolutely needed here but since it's late in the release I've
just done a minimal change

The 2nd review comment was about the Indirect, Settings window being modal
in Workbench but not in MantidPlot. The IndirectSettings widget in MantidPlot
isn't an independent window and is embedded two levels down below the parent
window. So before this change the windowModality setting in the IndirectSettings.ui
file wasn't doing anything when settings was accessed directly from the Indirect
menu (windowModality only meaningful for independent windows). So I have copied
the modality setting read from the .ui file up two levels and it now works.

re #27319

Problem was caused by Qt::ApplicationModal being used instead of Qt::WindowModal
when displaying the settings screen from any of the Indirect interfaces

Had to also set up parents on Qt windows in order for Qt::WindowModal to work:
a) set up parent on the Indirect settings Qt widget when created from any of the
Indirect interface screens
b) set up parent on the C++ GUIs created from Workbench. All the indirect interfaces
are of this type + one or two others eg Direct, ALF View, Indirect Settings when
accessed from Indirect menu rather than via one of the interfaces

Main change is to add an overload of registerFeatureUsage that accepts a
simple string in addition to the existing method that takes a vector of strings

Update some further calls to registerFeatureUsage that had appeared in master
Also change trimming behaviour so trimming of feature names is done on copy
rather than in place

Now accepts:
- an enum for feature type rather than a string eg Algorithm
- a vector of strings for the feature name instead of string (eg class1->method1)

Also updated pre-existing calls to registerFeatureUsage in C++ and Python

Dependencies now go into Frameworks as seems to be done for
other application bundles. This should bring us close to
be able to sign the app bundle

Use macOS over OSX to refer to system.
Remove old OSX version workarounds
Refs #26261

Resolve problem with workspace index being set to 0 when fit window activated
using icon on MantidPlot toolbar. The show call also sets the workspace index
to zero. Moving the show call earlier means it happens before call to setWorkspaceIndex

Signed-off-by: Jose Borreguero <borreguero@gmail.com>