Also clear parameters that are to be replaced.
UNIT TEST STILL FAILS FOR THIS.

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Also ignore correction file, if workspace has no available start date, as in unit tests.

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Code untested. Code to interpret result of parsing to be added.

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Also log parameter file name not yet used, to satisfy cppcheck and it also makes testing easier, because one can setting logging to debug mode instead of using debugger.

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

LoadIDFFromNexusTest now also tests a parameter that is different in the embedded parameters than in the parameter file, so that loading of the embedded parameters is tested.

Also this test revealed a bug in the code, which is also fixed in this commit.

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

This rearrangement crashes in the unit test, when returning, owing so some access violation error in the ::NeXus::File object.

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

 1. Change the filename reported for nexus files if xml contained within
 1. Stop saving the filename to nexus processed files
 1. removed some unused includes

Still to do:
 1. cache SHA1 checksum if needed
 1. Manually test
 1. update documentation
 1. investigate this error:

ctest -C Debug -J 4 -R LoadEventNexusTest -V

 548: LoadParameterFile-[Error] Bad path syntax: C:\Mantid\Code\Mantid\instrument
\C:\Users\rrc79113\AppData\Roaming\mantidproject\mantid\instrument\HYSPECA_Param
eters.xml. Unable to parse File: in C:/Mantid/Code/Mantid/instrument//C:\Users\r
rc79113\AppData\Roaming\mantidproject\mantid\instrument\HYSPECA_Parameters.xml
548: LoadIDFFromNexus-[Notice] Instrument parameter file: C:\Users\rrc79113\AppD
ata\Roaming\mantidproject\mantid\instrument\HYSPECA_Parameters.xml not found or
un-parsable. Instrument parameter file: C:/Mantid/Code/Mantid/instrument/HYSPECA
_Parameters.xml has been loaded

re #11818

Replace all external calls to this static method with use of a child
algorithm instead.

Change the behaviour of LoadIDFFromNexus and before doing this,
as part of trying to ensure I wasn't broking something, updated
various code comments related to loading of xml files

The converted text is stored in separate .rst files in the docs directory.
Refs #9562

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

I also drilled it down into the execManually method changing its arguments.

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>