Moved code from FindPeaksMD into new method on Goniometer. Then added option onto peaks workspace.

No need for exclusion ranges, so code is cleaner. There is however now recursion, so performance will need to be tracked.

These fixes were not applied by clang-tidy because they are either
inside a macro, not included by any source files or conditionally
compiled on a condition which is false on my OS.

They were found using grep -rnI '^[^/#*]*typedef' Framework/

Elliot Oram authored 7 years ago and Gigg, Martyn Anthony committed 7 years ago

PredictFractionalPeaks was using a new raytracer for every peak it created and therefore throwing away the caching information about the bounding boxs of detectors / panels causing a huge slow down. Resolved by exposing the findDetector(raytracer) overload to IPeaks and using single raytracer for all calls.
Work also include small refactor for const autos

Refs #22060

Use delegating constructors to remove common init and remove
duplicate check for up and beam direction being the same.