I should probably get round to working out how to call it locally...

Included moving a TS_ASSERT out of a destructor in a mock object, which would have been harmless.  I couldn't use noexcept(false) as a workaround because of the parent destructor.  The resulting code is much messier as I have to keep ahold of the mock object and call the assert in each of the tests... :(

I haven't added a PrecompiledHeader.h yet.  I'd be open to adding one in this PR if a reviewer thought it was important enough.

We now conform to the standard format.  This change will help with server-side debugging when calling APIs.

Since the indexing is into the full array, use the full array
Refs #22286

Refs #22286

Refs #22286

Refs #22286

It was corrupting the values in the workspace and nothing was
getting set correctly. Refs #22286

Refs #22286

This is in an effort to sort out platform dependencies
Refs #22286

Refs #22383

Refs #22383

OSX
FAILED: Framework/SINQ/test/CMakeFiles/PSISINQTest.dir/PoldiIndexKnownCompoundsTest.cpp.o
In file included from Framework/SINQ/test/PoldiIndexKnownCompoundsTest.cpp:17:
PoldiIndexKnownCompoundsTest.h:40:5: error: no matching function for call to 'storeWS'
    WorkspaceCreationHelper::storeWS(
WorkspaceCreationHelper.h:114:33: note: candidate function [with WSType = boost::shared_ptr<Mantid::DataObjects::TableWorkspace>] not viable: expects an l-value for 2nd argument
template <typename WSType> void storeWS(const std::string &name, WSType &ws) {
In file included from Framework/SINQ/test/PoldiIndexKnownCompoundsTest.cpp:17:
PoldiIndexKnownCompoundsTest.h:43:5: error: no matching function for call to 'storeWS'
    WorkspaceCreationHelper::storeWS(
WorkspaceCreationHelper.h:114:33: note: candidate function [with WSType = boost::shared_ptr<Mantid::DataObjects::TableWorkspace>] not viable: expects an l-value for 2nd argument
template <typename WSType> void storeWS(const std::string &name, WSType &ws) {
In file included from Framework/SINQ/test/PoldiIndexKnownCompoundsTest.cpp:17:
PoldiIndexKnownCompoundsTest.h:673:7: error: no matching function for call to 'storeWS'
      WorkspaceCreationHelper::storeWS(
WorkspaceCreationHelper.h:114:33: note: candidate function [with WSType = boost::shared_ptr<Mantid::DataObjects::Workspace2D>] not viable: expects an l-value for 2nd argument
template <typename WSType> void storeWS(const std::string &name, WSType &ws) {
3 errors generated.

Linux
PoldiIndexKnownCompoundsTest.h:42:66: error: invalid initialization of non-const reference of type ‘boost::shared_ptr<Mantid::DataObjects::TableWorkspace>&’ from an rvalue of type ‘Mantid::DataObjects::TableWorkspace_sptr {aka boost::shared_ptr<Mantid::DataObjects::TableWorkspace>}’
          PoldiPeakCollectionHelpers::createPoldiPeakTableWorkspace());
PoldiIndexKnownCompoundsTest.cpp:17:
WorkspaceCreationHelper.h:114:33: note:   initializing argument 2 of ‘void WorkspaceCreationHelper::storeWS(const string&, WSType&) [with WSType = boost::shared_ptr<Mantid::DataObjects::TableWorkspace>; std::__cxx11::string = std::__cxx11::basic_string<char>]’
10:35:30  template <typename WSType> void storeWS(const std::string &name, WSType &ws) {
PoldiIndexKnownCompoundsTest.cpp:17:0:
PoldiIndexKnownCompoundsTest.h:46:31: error: invalid initialization of non-const reference of type ‘boost::shared_ptr<Mantid::DataObjects::TableWorkspace>&’ from an rvalue of type ‘Mantid::DataObjects::TableWorkspace_sptr {aka boost::shared_ptr<Mantid::DataObjects::TableWorkspace>}’
              ->asTableWorkspace());
WorkspaceCreationHelper.h:114:33: note:   initializing argument 2 of ‘void WorkspaceCreationHelper::storeWS(const string&, WSType&) [with WSType = boost::shared_ptr<Mantid::DataObjects::TableWorkspace>; std::__cxx11::string = std::__cxx11::basic_string<char>]’
  template <typename WSType> void storeWS(const std::string &name, WSType &ws) {
PoldiIndexKnownCompoundsTest.cpp:17:0:
PoldiIndexKnownCompoundsTest.h: In member function ‘void PoldiIndexKnownCompoundsTest::storeRandomWorkspaces(const std::vector<std::__cxx11::basic_string<char> >&)’:
PoldiIndexKnownCompoundsTest.h:674:65: error

Refs #22383

Refs #22383

- Doxygen updated (throws)
- Templated storeWS

Running ConjoinXRunsTest for testTableInputWorkspaceInGroupThrows:
ConjoinXRuns-[Warning] Invalid value for InputWorkspaces: Workspace table is not a MatrixWorkspace

showing the need to check !ws and + input + works (ll 128,130 in ConjoinXRuns.cpp)

Refs #22383