Re #23570 cppcheck fixes

MantidPlot/src/ProjectRecoveryGUIs/ProjectRecoveryModel.cpp

@@ -61,7 +61,7 @@ std::vector<std::string> ProjectRecoveryModel::getRow(int i) {
 }
 
 std::vector<std::string>
-ProjectRecoveryModel::getRow(std::string checkpointName) {
+ProjectRecoveryModel::getRow(const std::string &checkpointName) {
   for (auto c : m_rows) {
     if (c[0] == checkpointName) {
       return c;

MantidPlot/src/ProjectRecoveryGUIs/ProjectRecoveryModel.h

@@ -20,7 +20,7 @@ public:
   ProjectRecoveryModel(MantidQt::ProjectRecovery *projectRecovery,
                        ProjectRecoveryPresenter *presenter);
   std::vector<std::string> getRow(int i);
-  std::vector<std::string> getRow(std::string checkpointName);
+  std::vector<std::string> getRow(const std::string &checkpointName);
   void startMantidNormally();
   void recoverSelectedCheckpoint(std::string &selected);
   void openSelectedInEditor(std::string &selected);

MantidPlot/src/ProjectRecoveryGUIs/ProjectRecoveryPresenter.cpp

@@ -20,6 +20,7 @@ ProjectRecoveryPresenter::ProjectRecoveryPresenter(
   m_recView = nullptr;
   m_failureView = nullptr;
   m_model = new ProjectRecoveryModel(projectRecovery, this);
+  m_openView = RecoveryView;
 }
 
 ProjectRecoveryPresenter::ProjectRecoveryPresenter(
@@ -30,6 +31,7 @@ ProjectRecoveryPresenter::ProjectRecoveryPresenter(
   m_model = new ProjectRecoveryModel(nullptr, this);
   *m_model = *obj.m_model;
   m_mainWindow = obj.m_mainWindow;
+  m_openView = = obj.m_openView;
 }
 
 ProjectRecoveryPresenter::~ProjectRecoveryPresenter() {
@@ -122,6 +124,7 @@ operator=(const ProjectRecoveryPresenter &obj) {
     m_model = new ProjectRecoveryModel(nullptr, this);
     *m_model = *obj.m_model;
     m_mainWindow = obj.m_mainWindow;
+    m_openView = obj.m_openView;
   }
   return *this;
 }