Re #21691: Completed refl gui + data processor plumbing required

qt/scientific_interfaces/ISISReflectometry/IReflMainWindowPresenter.h

@@ -2,6 +2,7 @@
 #define MANTID_ISISREFLECTOMETRY_IREFLMAINWINDOWPRESENTER_H
 
 #include "MantidQtWidgets/Common/DataProcessorUI/OptionsQMap.h"
+#include "MantidQtWidgets/Common/DataProcessorUI/TreeData.h"
 
 #include <string>
 
@@ -43,6 +44,9 @@ public:
   enum class Flag { ConfirmReductionPausedFlag, ConfirmReductionResumedFlag };
   virtual void notify(Flag flag) = 0;
 
+  virtual void completedReductionSuccessfully(
+      MantidWidgets::DataProcessor::GroupData const &group) = 0;
+
   /// Pre-processing
   virtual std::string getTransmissionRuns(int group) const = 0;
   virtual MantidWidgets::DataProcessor::OptionsQMap

qt/scientific_interfaces/ISISReflectometry/IReflSaveTabPresenter.h

 #ifndef MANTID_ISISREFLECTOMETRY_IREFLSAVETABPRESENTER_H
 #define MANTID_ISISREFLECTOMETRY_IREFLSAVETABPRESENTER_H
+#include "MantidQtWidgets/Common/DataProcessorUI/TreeData.h"
 
 namespace MantidQt {
 namespace CustomInterfaces {
@@ -46,6 +47,9 @@ public:
     suggestSaveDirFlag
   };
 
+  virtual void completedReductionSuccessfully(
+      MantidWidgets::DataProcessor::GroupData const &group) = 0;
+
   /// Tell the presenter something happened
   virtual void notify(IReflSaveTabPresenter::Flag flag) = 0;
 };

qt/scientific_interfaces/ISISReflectometry/ReflDataProcessorPresenter.cpp

@@ -266,6 +266,11 @@ bool ReflDataProcessorPresenter::processGroupAsEventWS(
   return errors;
 }
 
+void ReflDataProcessorPresenter::completedReductionSuccessfully(
+    MantidWidgets::DataProcessor::GroupData const &groupData) {
+  m_mainPresenter->completedReductionSuccessfully(groupData);
+}
+
 /** Processes a group of non-event workspaces
 *
 * @param groupID :: An integer number indicating the id of this group

qt/scientific_interfaces/ISISReflectometry/ReflDataProcessorPresenter.h

@@ -59,6 +59,7 @@ public:
   // Add entry for the number of slices for all rows in a group
   void addNumGroupSlicesEntry(int groupID, size_t numSlices);
 
+  void completedReductionSuccessfully(GroupData const& groupData) override;
 private:
   // Process selected rows
   void process() override;

qt/scientific_interfaces/ISISReflectometry/ReflMainWindowPresenter.cpp

@@ -41,6 +41,10 @@ ReflMainWindowPresenter::ReflMainWindowPresenter(
 */
 ReflMainWindowPresenter::~ReflMainWindowPresenter() {}
 
+void ReflMainWindowPresenter::completedReductionSuccessfully(GroupData const &group) {
+  m_savePresenter->completedReductionSuccessfully(group);
+}
+
 /**
 Used by the view to tell the presenter something has changed
 */

qt/scientific_interfaces/ISISReflectometry/ReflMainWindowPresenter.h

@@ -85,6 +85,8 @@ public:
 
   void settingsChanged(int group) override;
 
+  void completedReductionSuccessfully(MantidWidgets::DataProcessor::GroupData const &group) override;
+
 private:
   /// Check for Settings Tab null pointer
   void checkSettingsPtrValid(IReflSettingsTabPresenter *pointer) const;

qt/scientific_interfaces/ISISReflectometry/ReflRunsTabPresenter.cpp

@@ -159,6 +159,11 @@ void ReflRunsTabPresenter::notify(IReflRunsTabPresenter::Flag flag) {
   // a flag we aren't handling.
 }
 
+void ReflRunsTabPresenter::completedReductionSuccessfully(
+    GroupData const &group) {
+  m_mainPresenter->completedReductionSuccessfully(group);
+}
+
 /** Pushes the list of commands (actions) */
 void ReflRunsTabPresenter::pushCommands() {
 

qt/scientific_interfaces/ISISReflectometry/ReflRunsTabPresenter.h

@@ -5,6 +5,7 @@
 #include "DllConfig.h"
 #include "IReflRunsTabPresenter.h"
 #include "MantidQtWidgets/Common/DataProcessorUI/DataProcessorMainPresenter.h"
+#include "MantidQtWidgets/Common/DataProcessorUI/TreeData.h"
 #include <boost/shared_ptr.hpp>
 
 namespace MantidQt {
@@ -86,6 +87,7 @@ public:
   void confirmReductionPaused() const override;
   void confirmReductionResumed() const override;
   void settingsChanged(int group) override;
+  void completedReductionSuccessfully(MantidWidgets::DataProcessor::GroupData const& group) override;
 
 private:
   /// The search model

qt/scientific_interfaces/ISISReflectometry/ReflSaveTabPresenter.cpp

@@ -61,6 +61,11 @@ void ReflSaveTabPresenter::notify(IReflSaveTabPresenter::Flag flag) {
   }
 }
 
+void ReflSaveTabPresenter::completedReductionSuccessfully(
+    MantidWidgets::DataProcessor::GroupData const &group) {
+  std::cout << "Reduced group with size " << group.size() << std::endl;
+}
+
 /** Fills the 'List of Workspaces' widget with the names of all available
 * workspaces
 */
@@ -212,4 +217,4 @@ std::vector<std::string> ReflSaveTabPresenter::getAvailableWorkspaceNames() {
   return validNames;
 }
 }
-}
+}
\ No newline at end of file

qt/scientific_interfaces/ISISReflectometry/ReflSaveTabPresenter.h

@@ -49,6 +49,7 @@ public:
   /// Accept a main presenter
   void acceptMainPresenter(IReflMainWindowPresenter *mainPresenter) override;
   void notify(IReflSaveTabPresenter::Flag flag) override;
+  void completedReductionSuccessfully(MantidWidgets::DataProcessor::GroupData const& group) override;
 
 private:
   /// Adds all workspace names to the list of workspaces

qt/widgets/common/CMakeLists.txt

@@ -54,6 +54,7 @@ set ( SRC_FILES
 	src/CatalogSelector.cpp
 	src/CheckboxHeader.cpp
 	src/DataProcessorUI/AbstractTreeModel.cpp
+	src/DataProcessorUI/TreeData.cpp
 	src/DataProcessorUI/GenerateNotebook.cpp
 	src/DataProcessorUI/OneLevelTreeManager.cpp
         src/DataProcessorUI/OptionsMap.cpp

qt/widgets/common/inc/MantidQtWidgets/Common/DataProcessorUI/DataProcessorMainPresenter.h

@@ -3,6 +3,7 @@
 
 #include "MantidKernel/System.h"
 #include "MantidQtWidgets/Common/DataProcessorUI/OptionsQMap.h"
+#include "MantidQtWidgets/Common/DataProcessorUI/TreeData.h"
 
 #include <QSet>
 #include <QString>
@@ -74,6 +75,7 @@ public:
   /// Handle data reduction paused/resumed confirmation
   virtual void confirmReductionPaused() const {}
   virtual void confirmReductionResumed() const {}
+  virtual void completedReductionSuccessfully(GroupData const&) {};
 };
 }
 }

qt/widgets/common/inc/MantidQtWidgets/Common/DataProcessorUI/GenericDataProcessorPresenter.h

@@ -213,6 +213,7 @@ protected:
   // Plotting
   virtual void plotRow();
   virtual void plotGroup();
+  virtual void completedReductionSuccessfully(GroupData const& groupData);
   void plotWorkspaces(const QOrderedSet<QString> &workspaces);
   // Get the name of a post-processed workspace
   QString getPostprocessedWorkspaceName(const GroupData &groupData);
@@ -223,6 +224,7 @@ protected slots:
   void issueNotFoundWarning(QString const &granule,
                             QSet<QString> const &missingWorkspaces);
 
+
 private:
   void applyDefaultOptions(std::map<QString, QVariant> &options);
   void setPropertiesFromKeyValueString(Mantid::API::IAlgorithm_sptr alg,

qt/widgets/common/inc/MantidQtWidgets/Common/DataProcessorUI/TreeData.h

@@ -38,6 +38,7 @@ namespace DataProcessor {
 using RowData = QStringList;
 using GroupData = std::map<int, RowData>;
 using TreeData = std::map<int, GroupData>;
+bool canPostprocess(GroupData const& group);
 }
 }
 }

qt/widgets/common/src/DataProcessorUI/GenericDataProcessorPresenter.cpp

@@ -417,6 +417,7 @@ void GenericDataProcessorPresenter::nextRow() {
     // single row
     if (!isProcessed(groupIndex) && m_groupData.size() > 1) {
       startAsyncGroupReduceThread(m_groupData, groupIndex);
+      completedReductionSuccessfully(m_groupData);
       return;
     }
   }
@@ -425,6 +426,9 @@ void GenericDataProcessorPresenter::nextRow() {
   doNextAction();
 }
 
+void GenericDataProcessorPresenter::completedReductionSuccessfully(
+    GroupData const &) {}
+
 /**
 Process a new group
 */
@@ -437,9 +441,6 @@ void GenericDataProcessorPresenter::nextGroup() {
     return;
   }
 
-  // Clear group data from any previously processed groups
-  m_groupData.clear();
-
   if (!m_group_queue.empty()) {
     // Set next action flag
     m_nextActionFlag = ReductionFlag::ReduceRowFlag;
@@ -458,6 +459,8 @@ void GenericDataProcessorPresenter::nextGroup() {
       saveNotebook(m_selectedData);
     endReduction();
   }
+  // Clear group data from any previously processed groups
+  m_groupData.clear();
 }
 
 /*

qt/widgets/common/src/DataProcessorUI/TreeData.cpp

+#include "MantidQtWidgets/Common/DataProcessorUI/TreeData.h"
+
+namespace MantidQt {
+namespace MantidWidgets {
+namespace DataProcessor {
+bool canPostprocess(GroupData const &group) { return group.size() > 1; }
+}
+}
+}