Kill some compiler warnings. Refs #5742

Code/Mantid/Framework/API/src/PropertyNexus.cpp

@@ -80,7 +80,7 @@ namespace PropertyNexus
     std::vector<bool> realValues(nvals);
     for(size_t i = 0; i < nvals; ++i)
     {
-      realValues[i] = static_cast<bool>(savedValues[i]);
+      realValues[i] = (savedValues[i] != 0);
     }
     TimeSeriesProperty<bool> * prop = new TimeSeriesProperty<bool>(name);
     prop->addValues(times, realValues);

Code/Mantid/Framework/API/test/ModeratorModelTest.h

@@ -13,7 +13,7 @@ public:
   boost::shared_ptr<ModeratorModel> clone() const { return boost::shared_ptr<MockModerator>(); }
   MOCK_CONST_METHOD0(emissionTimeMean, double());
   MOCK_CONST_METHOD0(emissionTimeVariance, double());
-  MOCK_CONST_METHOD1(sampleTimeDistribution, double(const double randNo));
+  MOCK_CONST_METHOD1(sampleTimeDistribution, double(const double));
   MOCK_METHOD2(setParameterValue, void(const std::string &, const std::string &));
 };
 

Code/Mantid/Framework/CurveFitting/src/LeBailFunction.cpp

@@ -3,8 +3,6 @@
 #include "MantidAPI/FunctionFactory.h"
 #include <gsl/gsl_sf_erf.h>
 
-#define PEAKRADIUS 8.0
-
 using namespace Mantid::Kernel;
 using namespace Mantid::API;
 
@@ -12,6 +10,10 @@ namespace Mantid
 {
 namespace CurveFitting
 {
+  namespace
+  {
+    const int PEAKRADIUS = 8.0;
+  }
 
 //  DECLARE_FUNCTION(LeBailFunction)
 

Code/Mantid/Framework/DataObjects/inc/MantidDataObjects/SplittersWorkspace.h

@@ -6,6 +6,10 @@
 #include "MantidKernel/TimeSplitter.h"
 #include "MantidDataObjects/TableWorkspace.h"
 
+#ifdef _MSC_VER
+  #pragma warning( disable: 4250 ) // Disable warning regarding inheritance via dominance
+#endif
+
 namespace Mantid
 {
 namespace DataObjects

Code/Mantid/Framework/DataObjects/src/EventList.cpp

@@ -26,9 +26,11 @@ namespace DataObjects
   using Kernel::DateAndTime;
   using namespace Mantid::API;
 
-  /// The number of events to split for parallel sorting.
-  const size_t NUM_EVENTS_PARALLEL_THRESHOLD(5e5);
-
+  namespace
+  {
+    /// The number of events to split for parallel sorting.
+    const size_t NUM_EVENTS_PARALLEL_THRESHOLD = 500000;
+  }
   //==========================================================================
   /// --------------------- TofEvent Comparators ----------------------------------
   //==========================================================================

Code/Mantid/Framework/WorkflowAlgorithms/src/WorkflowAlgorithmHelpers.cpp

@@ -81,7 +81,7 @@ namespace WorkflowAlgorithmHelpers
       std::vector<double> params = ws->getInstrument()->getNumberParameter(instParam);
       if (!params.empty())
       {
-        param = static_cast<bool>(params[0]);
+        param = (params[0] != 0.0);
       }
     }
     if(defaultValue != overrideValue)

Code/Mantid/MantidQt/RefDetectorViewer/src/RefArrayDataSource.cpp

@@ -44,6 +44,7 @@ RefArrayDataSource::RefArrayDataSource( double total_xmin, double total_xmax,
 
     RefArrayDataSource::RefArrayDataSource(QString wps_name):RefImageDataSource(10,10,20,20,10,20)
 {
+    Q_UNUSED(wps_name);
     std::cout << "Inside RefArrayDataSource" << std::endl;
 
     

Code/Mantid/MantidQt/RefDetectorViewer/src/RefMatrixWSImageView.cpp

@@ -33,31 +33,31 @@ RefMatrixWSImageView::RefMatrixWSImageView( QString wps_name)
     IEventWorkspace_sptr ws;
     ws = AnalysisDataService::Instance().retrieveWS<IEventWorkspace>(wps_name.toStdString());
     
-    double total_ymin = 0;
-    double total_ymax = 255;
-    size_t total_rows = 256;
+    const double total_ymin = 0.0;
+    const double total_ymax = 255.0;
+    const size_t total_rows = 256;
 
     std::vector<double> xaxis = ws->readX(0);
-    size_t sz = xaxis.size();
-    size_t total_cols = sz-1;
+    const size_t sz = xaxis.size();
+    const size_t total_cols = sz-1;
     
     double total_xmin = xaxis[0];
     double total_xmax = xaxis[sz-1];
     
-    float *data = new float[size_t(total_ymax * sz)];
+    float *data = new float[static_cast<size_t>(total_ymax) * sz];
     
 //    std::cout << "Starting the for loop " << std::endl;
 //    std::cout << "total_xmax: " << total_xmax << std::endl;
 //    std::cout << "sz is : " << sz << std::endl;
     
     std::vector<double> yaxis;
-    for (int px=0; px<total_ymax; px++)
+    for (size_t px=0; px<total_ymax; px++)
     {
         //retrieve data now
         yaxis = ws->readY(px);
         for (size_t tof=0; tof<sz-1; tof++)
         {
-            data[px*sz + tof] = yaxis[tof];
+            data[px*sz + tof] = static_cast<float>(yaxis[tof]);
         }
     }
     

Code/Mantid/MantidQt/SliceViewer/src/PeakOverlayFactoryBase.cpp

@@ -34,13 +34,13 @@ namespace MantidQt
       Mantid::Kernel::V3D position;
       switch(m_peakDims)
       {
-      case PeakDimensions::LabView:
+      case LabView:
         position = peak.getQLabFrame();
         break;
-      case PeakDimensions::SampleView:
+      case SampleView:
         position = peak.getQSampleFrame();
         break;
-      case PeakDimensions::HKLView:
+      case HKLView:
         position = peak.getHKL();
         break;
       default:
@@ -64,4 +64,4 @@ namespace MantidQt
     }
 
   }
-}
\ No newline at end of file
+}