Skip to content
Snippets Groups Projects
Commit e1bbfe01 authored by Conor Finn's avatar Conor Finn
Browse files

RE #27188 Fix buttons staying disabled on worker error

parent c945c039
No related branches found
No related tags found
No related merge requests found
......@@ -13,7 +13,6 @@ from Engineering.gui.engineering_diffraction.tabs.common.vanadium_corrections im
from Engineering.gui.engineering_diffraction.tabs.common.cropping.cropping_widget import CroppingWidget
from mantidqt.utils.asynchronous import AsyncTask
from mantidqt.utils.observer_pattern import Observer
from mantid.simpleapi import logger
class FocusPresenter(object):
......@@ -95,8 +94,7 @@ class FocusPresenter(object):
return False
return True
def _on_worker_error(self, failure_info):
logger.warning(str(failure_info))
def _on_worker_error(self, _):
self.emit_enable_button_signal()
def set_focus_controls_enabled(self, enabled):
......
......@@ -76,14 +76,12 @@ class FocusPresenterTest(unittest.TestCase):
self.view.set_plot_output_enabled.assert_called_with(True)
@patch(tab_path + ".presenter.FocusPresenter.emit_enable_button_signal")
@patch(tab_path + ".presenter.logger.warning")
def test_on_worker_error_posts_to_logger_and_enables_controls(self, logger, emit):
def test_on_worker_error_posts_to_logger_and_enables_controls(self, emit):
fail_info = 2024278
self.presenter._on_worker_error(fail_info)
logger.assert_called_with(str(fail_info))
self.assertEqual(emit.call_count, 1)
self.assertEqual(1, emit.call_count)
def test_get_both_banks(self):
self.view.get_crop_checked.return_value = False
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment